Sean Meighan

Software => Bugs in xLights/Nutcracker => Bugs (Please dont post here, soon to be deprecated) => Topic started by: Phrog30 on April 07, 2015, 01:37:10 PM

Title: XL4 convert .vix
Post by: Phrog30 on April 07, 2015, 01:37:10 PM

XL4 convert vix files.  I tried to convert a .vix file .xseg in XL4.0.16.  It failed, said no channels.  The same files converts in XL3.6.15 with no problem.  Not sure if this has been discussed yet, but thought I would mention.

Thanks,
James

Title: Re: XL4 convert .vix
Post by: flyinverted on April 07, 2015, 02:20:30 PM

Open a ticket at https://github.com/smeighan/xLights/issues (https://github.com/smeighan/xLights/issues)

Title: Re: XL4 convert .vix
Post by: Gilrock on April 07, 2015, 02:40:33 PM

There is already an open ticket for the Vixen import issue.  I just didn't understand enough about it yet to know what's wrong.  I didn't think we changed any of that convert code functionality wise.

Title: Re: XL4 convert .vix
Post by: sean on April 07, 2015, 04:48:47 PM

i did verify that 3.6 will convert the attached vix file correctly and fails to convert in xl 4. it is certainly a bug.
this is a small vixen file from 2013 i have used for testing in the past.



[attachment deleted by admin]

Title: Re: XL4 convert .vix
Post by: Gilrock on April 07, 2015, 07:30:18 PM

Ok I found the bug and luckily Git Blame didn't show my name...whew.

Anyways another issue cropped up once it got further along in the conversion.  The file I was using was 25ms in Vixen and our xLights writer code currently complains if the sequence isn't 50ms.  We also have the new timing selector on the convert tab so do I ignore that for a Vixen file since it appears to define the frame timing in the file?

Title: Re: XL4 convert .vix
Post by: Gilrock on April 07, 2015, 07:33:18 PM

Well I guess the timing error is because I chose xseq for the output format which still has the 50ms restriction so I can probably checkin the change as is.

Title: Re: XL4 convert .vix
Post by: sean on April 07, 2015, 07:33:25 PM

I would like if 25ms vix files would come across as 25ms. As a minimum I think we would duplicate xl 3.6 and force all vixen files into 50ms


Sent from my iPhone using Tapatalk

Title: Re: XL4 convert .vix
Post by: sean on April 07, 2015, 07:34:31 PM

Gil, thanks (again) for fixing another bug!


Sent from my iPhone using Tapatalk

Title: Re: XL4 convert .vix
Post by: Gilrock on April 07, 2015, 07:42:23 PM

Well I don't think we have all the i's dotted and t's crossed for the various timing settings.  I think you can import a 25ms file as 25ms but if you had opened a 50ms file and import a 25ms Vixen file it will probably import but not match up.  So currently there is some responsibility to the user to not mix incompatible timings because we don't have all the warnings in place.

Title: Re: XL4 convert .vix
Post by: Gilrock on April 07, 2015, 07:44:41 PM

Well I thought we had a issue ticket but haven't found it yet.