Sean Meighan

Software => Bugs in xLights/Nutcracker => Bugs (Please dont post here, soon to be deprecated) => Topic started by: egenoup on April 14, 2015, 08:19:34 PM

Title: GIF aminations in XL 4.0.20
Post by: egenoup on April 14, 2015, 08:19:34 PM

I tried to report this before, but I guess I choose the wrong forum ("Bugs in xLights/Nutcracker").

I am seeing an issue with XL4.0.x (I have loaded the latest as well) in where I have a GIF file that I put in a picture effect and I can not change the animation speed of the GIF.  The position of the "speed" slider does not seem to affect the speed.  The 20 fps check box does not affect the speed either. 

I loaded the 3.6.7 version of XL and the picture effect speed works as mostly as intended.  The speed slider changes the speed, but it is not linear and seems to skip around in the speed ranges. 

The following is a video of the issue, but it has no sound nor commentary  The first section shows what the actual gif play speed should be as it is playing in IE.  Then you can see me creating a quick animated sequence and adding the picture effect and the gif file.  When I move the slider or check the "20fps" button, the speed is unaffected.  If you want to see timing, look at the clock above.  You can see the frames are about one per second regardless of the slider or checkbox. 

https://vimeo.com/124999961 (https://vimeo.com/124999961)

Thanks,

Charles

Title: Re: GIF aminations in XL 4.0.20
Post by: Gilrock on April 15, 2015, 12:07:57 AM

I saw this reported somewhere.  There are so many items being added into the issues list who knows when we can look at this.  It could be part of us trying to support multiple timings (25ms, 50ms, 100ms).

Title: Re: GIF aminations in XL 4.0.20
Post by: Gilrock on April 15, 2015, 12:13:13 AM

I just took a quick look at the code.  It appears that the is20fps flag only applies if you are using multiple images that end in -1, -2, -3, etc.  So it won't apply to a GIF file.  I don't have time to dig deeper tonight so I'm not sure if that was always that way or changed at some point.

Title: Re: GIF aminations in XL 4.0.20
Post by: JonB256 on April 15, 2015, 09:01:08 AM

I tried this also. An old "animated pirate" GIF.
The "Anim Gif Speed" slider made no difference.

But, if I set the Effect Setting for Movement to "None" and then adjusted the "Speed" slider on the Layer/Timing, I could change the speed from very slow to normal.

Title: Re: GIF aminations in XL 4.0.20
Post by: Gilrock on April 18, 2015, 09:53:26 AM

I noticed Dan fixed the speed parameter for the Pictures effect.  I'm using a GIF for an upcoming show and it affected all the work I had done to tune the speeds.  So before the gif speed slider had no effect because the wrong name was being passed to the function.  So I was using the master speed to fix things.  Now the speeds have all changed since the slider works.

There is still a problem with how the code is working though.  It's been easier to notice since I just checked in a change to add text fields so I know for sure I'm setting the same speed for the same gif in two different locations and the speed comes out different based on how far you drag the effect across the timeline.  The calculations do a modulus of a state variable and I'm finding that it hits certain boundaries so sometimes going from 16 to 15 is causing a dramatic reduction in speed.

Title: Re: GIF aminations in XL 4.0.20
Post by: egenoup on April 18, 2015, 11:45:51 AM

phewwww... Thanks for confirming that it is not just me!  It will get fixed when it gets fix.

Charles