Sean Meighan

Software => Bugs in xLights/Nutcracker => Bugs (Please dont post here, soon to be deprecated) => Topic started by: MrChristmas2000 on May 07, 2015, 06:57:52 PM

Title: Nutcracker Timing Mark Import Failure
Post by: MrChristmas2000 on May 07, 2015, 06:57:52 PM
When starting a new sequence and selecting the import timing marks no timing marks are imported.

This video explains the problem:
https://www.youtube.com/watch?v=clPKXZq-aLo
Title: Re: Nutcracker Timing Mark Import Failure
Post by: Gilrock on May 07, 2015, 10:30:49 PM
Thanks for catching that.  It's amazing how many times we've made a change elsewhere in the program that has broken timing imports.  This one broke when I added the support for choosing the different sequence timings (25ms, 50ms, and 100ms).  I was trying to read the sequence timing from a variable that wasn't set yet.  Before adding that support the variable was hard coded so it always worked but was hard coded to snap the timings to 25ms.  Now it will snap the timings to whatever is the chosen sequence timing.

I also discovered we had a crash when importing the same file twice so I made it keep appending "_1" to the name until it finds an unused name.
Title: Re: Nutcracker Timing Mark Import Failure
Post by: MrChristmas2000 on May 08, 2015, 06:06:23 AM
If you have selected 25ms as your base timing and export a model say to LSP will it now format that export with 25ms timing?

Will there ever be an option to export a model at either 25, 50 or 100ms?

Title: Re: Nutcracker Timing Mark Import Failure
Post by: Gilrock on May 08, 2015, 07:50:28 AM
Well that's a different topic of which I have no idea since I never dug into any of the export code.  You are lucky there were other developers before me that cared about getting data out of xLights because I would have coded it as the roach motel....data gets in but it doesn't get out.

Why not just try what you're asking then you can tell us what it does?
Title: Re: Nutcracker Timing Mark Import Failure
Post by: MrChristmas2000 on May 08, 2015, 09:16:00 AM
ROTF

I would agree with you if I could bring in my incan data and edit it within NC. I have many many hours invested into building my sequences and do not want to throw that programming away. There are a large group similar to me. When NC gains that ability I and others will no longer have need for exporting/importing to any other editor. It would also be budget prohibitive for me to replace those incan elements all at once.

It was Sean and myself that worked on getting Nutcracker to export models under the 3.X version. Something tells me that code may have to be modified to accommodate the new three base timing options.

Thanks for your quick response.

Tom
Title: Re: Nutcracker Timing Mark Import Failure
Post by: Gilrock on May 08, 2015, 09:41:28 AM
Yep I get that.  I was just curious what is the current behavior.  Have you tried and it's not working?
Title: Re: Nutcracker Timing Mark Import Failure
Post by: MrChristmas2000 on May 08, 2015, 11:05:40 AM
Actually I am experimenting now.

I first thought that the LSP model export wasn't working but I must have been doing something wrong. I just got an import to work into an LSP sequence. It even created the 25ms timing marks that otherwise has to be created manually in the LSP sequence.

It seems that NC will indeed export a sequence at the base timing that it was started at. I have not figured out yet how to convert a previous NC 50ms sequence to 25ms timing.

I will be tremendously happy when I figure out how to make the group copy work in NC.
Title: Re: Nutcracker Timing Mark Import Failure
Post by: Gilrock on May 08, 2015, 11:18:42 AM
We don't allow you to change the base timing yet.

Drag a yellow box around a few effect then Control-C...click in an empty area and Control-V.  Just remember the spot you click is going to be the position of the first element in the top row of your selection so if you select a group where the top effect is halfway in between your group selection then you need to account for that much space when you select the target position.  What part of that isn't working?  Start out small and try to select only a few effects to get the concept working.  There might be a problem with selecting too many we need to work out.  When you paste it will skip any effects that have something in the way.
Title: Re: Nutcracker Timing Mark Import Failure
Post by: MrChristmas2000 on May 08, 2015, 12:44:32 PM
Ok I figured out my copy problem.

If you let your yellow box go above the 1st channel and do a copy the paste does not actually copy that channel but paste a series of cells that have no effects.

It would be Great to have an undo.  :)
Title: Re: Nutcracker Timing Mark Import Failure
Post by: Phrog30 on May 08, 2015, 02:12:10 PM
+1 on undo.
Title: Re: Nutcracker Timing Mark Import Failure
Post by: MrChristmas2000 on May 08, 2015, 03:53:10 PM
I don't know if this is a bug or needs to be an enhancement request but I cannot highlight an area to copy that is larger than just the visible screen.
Title: Re: Nutcracker Timing Mark Import Failure
Post by: Gilrock on May 08, 2015, 04:52:56 PM
No but you can set the zoom to include however much you want before you copy.
Title: Re: Nutcracker Timing Mark Import Failure
Post by: MrChristmas2000 on May 08, 2015, 05:18:04 PM
While it might work to do small areas of this sample sequence.

If I try to select a larger section of the same sequence it becomes impossible on the larger area.

The timing marks are 25ms.
Title: Re: Nutcracker Timing Mark Import Failure
Post by: Gilrock on May 08, 2015, 06:17:28 PM
Turn off the timing marks and all that red disappears.  Yes you may be limited on how finely you can select but do you really need to copy half a song?  Maybe you'll need to copy in a couple pieces at a time.  I did the best I could to get multi-effect copy in there.  I don't foresee adding the ability to scroll while selecting anytime soon.
Title: Re: Nutcracker Timing Mark Import Failure
Post by: MrChristmas2000 on May 08, 2015, 06:34:23 PM
There are times when large chunks of a sequence are repeated and it would be nice to be able to grab those larger chunks of code and paste it in the next selection.

I believe it will become a highly requested feature as things progress.

Don't get me wrong, I do appreciate the ability to copy more than one cell.

I have played with the turning off of the timing track when performing the copy and that does give the ability to grab a larger chunk of code. Then you have to turn the timing marks back on to do the paste.

I am doing a lot of experimenting with it now.

Title: Re: Nutcracker Timing Mark Import Failure
Post by: Gilrock on May 08, 2015, 06:50:12 PM
You shouldn't need to turn timing marks on to do a paste.  I changed things so you can click right in the grid and it will select a 1 second area.  The beginning of that selection will be the start of the paste target point.  I've gotten where I rarely use timing marks now.  Also you can zoom in before you select the paint spot.  After you paste them you can select them and group move them.
Title: Re: Nutcracker Timing Mark Import Failure
Post by: MrChristmas2000 on May 08, 2015, 07:08:41 PM
Ok, thanks.

If you want to copy say 4 cells is it better to start the highlight box at the beginning or end of the selection?

Do you have to completely select a cell for it to be included in a copy?

If your select hangs over just a little on a cell will that cell be copied into the buffer as well?

Will there be a point where right click, cut, copy, paste will be implemented?

LSP has an interesting feature where if you can click on a track label and copy the whole track. Would that need to be put into the enhancements list?
Title: Re: Nutcracker Timing Mark Import Failure
Post by: Gilrock on May 09, 2015, 10:56:38 PM
Doesn't matter where you start the selection box...it's what gets highlights with pink that will copy. If any edge of the effect turns pink that effect will be copied.  The selection isn't currently selecting cells it only selects effects.  As far as enhancements I'm never sure when we might do them.