Sean Meighan

Software => Bugs in xLights/Nutcracker => Topic started by: T4Z on June 02, 2016, 10:16:02 AM

Title: 2016.33 - problem with colour wash effect.
Post by: T4Z on June 02, 2016, 10:16:02 AM

Hello all.
I have noticed a problem with 2016.33 and .34 with my colour washes. The "circular palette" box is checked on every colour wash if the count is set to 1. If the count is greater than 1 the circular palette box is unchanged. All of these boxes should be unchecked in the original sequence.

Thanks. Taz.

Title: Re: 2016.33 - problem with colour wash effect.
Post by: Gilrock on June 02, 2016, 11:13:37 AM

Are you talking about upgrading an older sequence?  If so we run it through code that makes adjustments to all the settings.  The Fit To Time stuff was removed so we have to make adjustments for that.  Below shows what will happen to the settings during the upgrade.  If you don't like a setting just change it and hit Save and it won't ever run through the upgrade code again.   If that's not it then I don't know what you meant.

        case EffectManager::eff_COLORWASH:
424             if (settings.Get("E_TEXTCTRL_ColorWash_Cycles", "") == "")
425             {
426                 double count = wxAtoi(settings.Get("E_SLIDER_ColorWash_Count", "1"));
427                 settings.erase("E_SLIDER_ColorWash_Count");
428                 if (settings["T_CHECKBOX_FitToTime"] == "1")
429                 {
430                     count = 1.0;
431                     settings["E_CHECKBOX_ColorWash_CircularPalette"] = "0";
432                 }
433                 else
434                 {
435                     settings["E_CHECKBOX_ColorWash_CircularPalette"] = "1";
436                 }
437                 settings["E_TEXTCTRL_ColorWash_Cycles"] = wxString::Format("%0.2f", count);
438             }
439

Title: Re: 2016.33 - problem with colour wash effect.
Post by: dkulp on June 02, 2016, 11:26:48 AM

Actually, it should have only gone into that if the version is older than 4.2.20.   That's a bug I introduced.   Just pushed a fix.

Title: Re: 2016.33 - problem with colour wash effect.
Post by: T4Z on June 02, 2016, 11:28:09 AM

Thanks for the reply. Sequence was done in 2016.32 and I didn't even notice the change until I upgraded to .34 but it also happens in .33. I will give your suggestion a whirl.

Thanks very much for the help.