Sean Meighan

Software => Bugs in xLights/Nutcracker => Topic started by: dmpeaceman on November 29, 2016, 07:58:32 AM

Title: Apostrophe's Fail & Crash on Timing Tracks on Mac v2016.52
Post by: dmpeaceman on November 29, 2016, 07:58:32 AM

After trying to open a sequence from a PC on my MAC, and getting crashes (with no crash log) I looked to narrow down the issue, and found it's "apostrophes" on the timing track labels.

There are 2 bugs here

Bug 1) Cannot put apostrophes on lyrics on timing track label a MAC  (get's replaced with a ?)

Reproduce steps:

1.1 Right click timing track, and select "Import Lyrics"
1.2 Enter any text that contains an apostrophe:  '
1.3 Click OK.

Result:  Apostrophe is replaced with a question mark: ?

2) Opening a sequence with apostrophes on the timing track label crashes on a MAC.

1.1  Open attached sequence file on MAC (contains apostrophe from a sequence created on a PC)

Result:  xLights Crashes


WORKAROUND:  Manually editing the sequence XML file to remove the apostrophes fixes the crashing issue.

Title: Re: Apostrophe's Fail & Crash on Timing Tracks on Mac v2016.52
Post by: dmpeaceman on November 29, 2016, 08:05:06 AM

Correction:  I was wrong on root cause.  It's not apostrophes - it's a special character apostrophe, presumably from windows.  That offending character was: ’  not '   However, that character DOES crash xlights.

Hopefully that helps.  Loading in apostrophes doesn't crash as I said, but they do get replaced with question marks.

Title: Re: Apostrophe's Fail & Crash on Timing Tracks on Mac v2016.52
Post by: dkulp on November 29, 2016, 12:22:43 PM

We'll definitely need to get the crash fixed...  However, we can only "draw" the "standard" ascii characters below the 127 character.   Thus, replacing with the ? is probably the right thing.

Title: Re: Apostrophe's Fail & Crash on Timing Tracks on Mac v2016.52
Post by: dmpeaceman on November 29, 2016, 02:43:19 PM

Makes sense. The apostrophe, or "single quote" is ascii dec 39.  So it's odd that it can't be displayed, even when typing it on a mac it's replaced with a ? mark.

Agreed that the wonky apostrophe from windows should be replaced with a ? mark, and not crash, as it's outside the 127 range.

Thanks.

Title: Re: Apostrophe's Fail & Crash on Timing Tracks on Mac v2016.52
Post by: dkulp on November 29, 2016, 03:00:04 PM

It's not a standard apostrophe.  If you look in your sequence, the "I'm" displays fine as that one is using the standard dec39.  The "you'll" is using something else.  you’ll   vs   you'll   (very slight difference)

In any case, it shouldn't crash.

Title: Re: Apostrophe's Fail & Crash on Timing Tracks on Mac v2016.52
Post by: dmpeaceman on November 29, 2016, 03:10:21 PM

yep - I got it...we're saying the same thing.  Thanks for the clarification!