Sean Meighan

Software => Bugs in xLights/Nutcracker => Topic started by: aERonAUtical1996 on December 12, 2016, 07:55:09 PM

Title: Dimming Curve File not updating DCPanel
Post by: aERonAUtical1996 on December 12, 2016, 07:55:09 PM

Not really sure how much this functionality is used, but I had some initial problems with selecting a Dimming Curve from a file.  I saw that Dan Kulp checked in an update to the baseline over the weekend indicating he fixed an issue with the file loading.

When testing it this afternoon, I think I found a bug.

If you select either a Single Dimming curve or RGB Dimming Curve from a file, the red, green and blue DCPanel objects are updated via the FilePickerChanged even handler.  But when you reopen the ModelDimmingCurveDialog again, the 3 panels are initialized to default values, the file picker is set to the appropriate filename, but the *DCPanel objects aren't updated.  I suspect there was an assumption, like the manual entry text/sliders, would fire off an update event when setting the values (ModelDimmingCurveDialog::Init method).  There doesn't appear to be an update event when the FilePicker is populated.

So to reproduce:
1. Select the DimmingCurve from a model on the layout tab.
2. Change the drop down select box to Single Curve From File.
3. Select a file. 
4. The red, green, blue DC panels update.
5. Click OK.
6. Click the DimmingCurve again.
7. The filename is populated, but the DCPanels are default values.

Title: Re: Dimming Curve File not updating DCPanel
Post by: Gilrock on December 13, 2016, 07:04:32 AM

Does the dimming curve file work or not?  Sounds like your just claiming it doesn't draw a pretty picture.

Title: Re: Dimming Curve File not updating DCPanel
Post by: dkulp on December 13, 2016, 08:50:58 AM

Just pushed a fix for the display part...

Title: Re: Dimming Curve File not updating DCPanel
Post by: aERonAUtical1996 on December 13, 2016, 05:31:41 PM

Thanks guys.  I think it is only a UI issue but honestly, I have not had an opportunity to test.  I was planning on doing that this evening after the lights go off.  I'll grab the latest and build from that.  I was attempting this afternoon to find where the dimming curve was applied while sitting in a 4 hr meeting... needless to say I didn't get very far :(

Title: Re: Dimming Curve File not updating DCPanel
Post by: dkulp on December 13, 2016, 06:16:45 PM

Expand out the nodes for the thing on the grid.   The node level data always displays the "raw" values in the fseq.   Thus, if the dimming curve is applied, you should be able to see it there.