Sean Meighan

Software => Bugs in xLights/Nutcracker => Topic started by: ozaz on December 06, 2017, 09:42:46 PM

Title: malformed xml tags
Post by: ozaz on December 06, 2017, 09:42:46 PM

Not sure if this is a bug, or something I did wrong ( probably the latter  :-[  )

Noticed a few sequences with malformed xml tags eg:

Code: [Select]

<comment/>
instead of:

Code: [Select]

<comment></comment>
Reason I was looking at code was the sequence was showing in xSchedule / Check Schedule as using twice as many channels as are configured to be sent out.

I recreated the sequence by creating a new sequence and mapping the previous sequence (great tip @keithsw1111 ) All the malformed xml tags were fixed. This also fixed the additional channels issue.

Question is - how did the malformed tags get there?
If it's a bug, could it be fixed please.
If it's something I did wrong, could you let me know so I don't do it again. :)


Note: sequence ran ok from xschedule ( a credit to the programmers )

Title: Re: malformed xml tags
Post by: keithsw1111 on December 07, 2017, 03:03:23 AM

What makes you think it is malformed. It looks ok to me.

Title: Re: malformed xml tags
Post by: sean on December 07, 2017, 11:48:00 AM

<comment/> is a shortcut for <comment></comment>. it is legal html

Quote from: ozaz on December 06, 2017, 09:42:46 PM

Not sure if this is a bug, or something I did wrong ( probably the latter  :-[  )

Noticed a few sequences with malformed xml tags eg:

Code: [Select]

<comment/>
instead of:

Code: [Select]

<comment></comment>
Reason I was looking at code was the sequence was showing in xSchedule / Check Schedule as using twice as many channels as are configured to be sent out.

I recreated the sequence by creating a new sequence and mapping the previous sequence (great tip @keithsw1111 ) All the malformed xml tags were fixed. This also fixed the additional channels issue.

Question is - how did the malformed tags get there?
If it's a bug, could it be fixed please.
If it's something I did wrong, could you let me know so I don't do it again. :)


Note: sequence ran ok from xschedule ( a credit to the programmers )

Title: Re: malformed xml tags
Post by: ozaz on December 07, 2017, 02:46:55 PM

what made me think it was malformed was it was the sequence showing double number of channels in check schedule. Beside comment and various other empty tags there was a few empty effects tags like that as well.

After redoing sequence all the empty tags where in format <xxxx></xxxx> there were no empty effects tags, and it passed the check schedule check.

I put 2 and 2 together and came up with 5   ;D   my bad

Thanks @sean for your answer wasn't aware that /  is a shortcut for ></.  You learn something new everyday or get reminded of something you forgot long ago :)