Sean Meighan

Software => Bugs in xLights/Nutcracker => Topic started by: AAH on May 06, 2019, 06:22:21 AM

Title: punctuation marks breaking phonemes
Post by: AAH on May 06, 2019, 06:22:21 AM
I'm currently on 2019.24 and sometime fairly recently xlights seems to have stopped ignoring punctuation marks in lyrics. When breaking down words as part of the lyric breakdown process if there is a punctuation mark directly after (and in the case of at least commas before as well) the word gets ignored/skipped as if it's not a valid word.
If for instance the lyric has a comma immediately after a work then that work gets skipped.
It's commas, quotation marks, semicolons at least that cause the problem.

Edited to include a lyric track as the fault is WEIRD.

At 17.1s into the track there is the word "walk". It breaks down fine. Put a comma after it and it ignores the word.

Using 32bit xlights btw.
Title: Re: punctuation marks breaking phonemes
Post by: AAH on May 06, 2019, 06:50:22 AM
Further info.
While creating a test sequence for Keith I created a lyric track with Keith, Keith Keith! as part of the lyrics. They worked fine. However in the lyric track I added above if I edit in the same word and punctuation marks at the 17.1s mark where I was playing with then they get ignored.
Title: Re: punctuation marks breaking phonemes
Post by: allknowing2012 on May 06, 2019, 04:27:52 PM
Perhaps edit the .xml file with notepad++ and see if there are hidden characters in the text?
Title: Re: punctuation marks breaking phonemes
Post by: AAH on May 07, 2019, 04:05:07 AM
When the fault is present it is possible for it to be triggered with standard keyboard entries.
Title: Re: punctuation marks breaking phonemes
Post by: AAH on May 08, 2019, 07:23:10 AM
Due to having a play on Zoom with a couple of guys I traced the fault further.
If you breakdown the phrase "Keith is a legend." with new Xlights releases the 2nd line loses the punctuation and becomes "Keith is a legend" broke down into words. Breaking down that further works fine. If however I have an old lyric track that has "Keith is a legend." as the 1st line then the punctuation will remain when it breaks down the 2nd line and the final word would be "legend.". When you breakdown that word you end up with no phoneme.
  For lyric tracks that start from scratch the removal of punctuation gets taken care of.  I am however re-doing about 14 of my old songs that have punctuation all through them which will be on the broken down words line.
Title: Re: punctuation marks breaking phonemes
Post by: Gilrock on May 08, 2019, 08:14:10 AM
I don't get that description because there is nothing that tracks whether a phrase was typed in 5 minutes ago or existed when you opened up the file so they get treated the same.  Unless you are saying when you type the phrase now it removes it immediately before you attempt to do the breakdown.
Title: Re: punctuation marks breaking phonemes
Post by: AAH on May 08, 2019, 09:10:37 PM
 I created a video that hopefully shows more clearly than my description what the problem is.
For new lyric tracks there's no problem. If you breakdown the words of an old lyric track and there is punctuation marks then that is where the problem occurs.
https://youtu.be/-AF9tgdQjNg (https://youtu.be/-AF9tgdQjNg)
Title: Re: punctuation marks breaking phonemes
Post by: keithsw1111 on May 09, 2019, 05:43:07 AM
Fixed
Title: Re: punctuation marks breaking phonemes
Post by: AAH on May 09, 2019, 06:45:21 AM
Fixed

Thanks Keith