Author Topic: Sequencer Grid & Model Preview Window  (Read 2572 times)

Offline kevinp

  • Sr. Member
  • ****
  • Posts: 373
    • View Profile
Sequencer Grid & Model Preview Window
« on: June 03, 2015, 05:37:56 PM »
Just introduced with 4.01.01, if you click a effect and the cell highlights, it does not show the effect within the model preview window. You need to click exactly in the middle of the effect (cursor will change) to highlight the effect only (not the cell) and then the preview works.

Not sure if this was intended to work this way now or not.

Running under OS X .

Opened a new issue ticket on GitHub #256
Kevin Pankratz
Blaine MN

Offline flyinverted

  • Administrator
  • Hero Member
  • *****
  • Posts: 756
    • View Profile
Re: Sequencer Grid & Model Preview Window
« Reply #1 on: June 03, 2015, 05:45:03 PM »
This is a known issue that did crop up recently.

Gil is working on being able to select an effect and giving us the option to move it up, down, left right, copy it, delete it drag it, skew the selection etc.  It's a work in progress.
Steve Giron
Maricopa County, AZ
xLights user with a boat-load of channels.

Do not ask to know all the answers, but ask to understand the question.

Offline Gilrock

  • Supporting Member
  • Hero Member
  • *
  • Posts: 6946
    • View Profile
Re: Sequencer Grid & Model Preview Window
« Reply #2 on: June 03, 2015, 05:56:47 PM »
Actually that was the intended behavior because Sean showed me how I had broken it back on April 28th.  The problem is if you have an effect in every cell then there is no way to select the grid underneath.  My change on April 28th to be able to grab and effect and move it made it where everywhere on the effect selected it whereas prior to that date it would have been a drag operation.

I'm open to ideas but we need to be able to select the left edge, the right edge, the entire effect, and the cell underneath.


Offline flyinverted

  • Administrator
  • Hero Member
  • *****
  • Posts: 756
    • View Profile
Re: Sequencer Grid & Model Preview Window
« Reply #3 on: June 03, 2015, 06:00:38 PM »
What do you have to select the timing grid under the effect for?  Is that so the start/stop (effect length) is captured?
Steve Giron
Maricopa County, AZ
xLights user with a boat-load of channels.

Do not ask to know all the answers, but ask to understand the question.

Offline Gilrock

  • Supporting Member
  • Hero Member
  • *
  • Posts: 6946
    • View Profile
Re: Sequencer Grid & Model Preview Window
« Reply #4 on: June 03, 2015, 06:08:33 PM »
Without the cell select you can't do a block select and delete anything if you have every cell filled.  Sean showed me that with his test_for_crash2 file.

Offline kevinp

  • Sr. Member
  • ****
  • Posts: 373
    • View Profile
Re: Sequencer Grid & Model Preview Window
« Reply #5 on: June 03, 2015, 06:14:27 PM »
That's OK if this was intended behavior.  I read Gil's response on Github on the opened issue before mine and it makes perfect sense.  I just need to educate myself on how to do old things a new way.  Now that I know what to do, all is good.  I'll close the open issue.
Kevin Pankratz
Blaine MN

Offline plaberge

  • Full Member
  • ***
  • Posts: 118
    • View Profile
    • Laberge Christmas Lights
Re: Sequencer Grid & Model Preview Window
« Reply #6 on: June 03, 2015, 09:16:16 PM »
I'm OK with this new behavior. In fact, I find it useful that the focus of the preview window does not shift as I move the cursor around.

Paul.
Paul.
Halfmoon Bay, BC

Offline Gilrock

  • Supporting Member
  • Hero Member
  • *
  • Posts: 6946
    • View Profile
Re: Sequencer Grid & Model Preview Window
« Reply #7 on: June 04, 2015, 07:31:42 AM »
Actually the behavior may have changed with this release.  I had to modify the code so that it selected effects within the selected cell boundary instead of where the actual mouse click started.  What that did is made it where if you select the cell it's going to select the effect.  Also now as you move the cursor around it will probably be selecting the effect you land on.  I say probably because I didn't test a single cell.  What I did test was moving a block selection around and it updates the selections as it's moved so I gotta assume it will be doing that with a single cell also but it was late when I tested so who knows what quirks I may have introduced.

Offline Gilrock

  • Supporting Member
  • Hero Member
  • *
  • Posts: 6946
    • View Profile
Re: Sequencer Grid & Model Preview Window
« Reply #8 on: June 04, 2015, 07:37:43 AM »
There are a couple new things about the grid selection.  One is that you can use the control key to add or remove individual effects from the current selection.  So now you can select an effect and another effect 3 cells down without selecting the ones in between.  The only thing I haven't decided I like is that you can also group move with control as well as shift which means you can accidentally move the group when trying to just add/remove an effect from the selection group.  I was thinking of removing control and only letting shift do the group moves but I want to check with everyone else first.  Another change is the grid selection should move as you scroll the screen up and down.  I'm sure it's not working right if you expand nodes though...you'll need to redefine the selection.

One thing that wasn't working that I didn't have time to fix is I made it where you can select a cell scroll over and shift select another cell without both cells being in the same view.  The grid selection is working but the effect selection underneath is not working for any offscreen effects.  I found the current underlying logic only supports selecting positions that are in view so I need to do some work to fix that.