xx 2016.12 xLights release. 3 bug fixes

[sean]

2016.12 release

Quick release to fix three issues. A person had models , partway off screen. The normal 6 second save grew to 180 seconds. This is now fixed

Second bug is a fix for corruption that occurs in the perspective section of xlights_rgbeffects.xml.

Third fix is to restore the PAUSE/STOP buttons in playback of effects. 2016.11 had disabled those buttons.

Latest releases are found at http://nutcracker123.com/nutcracker/releases/
Issue Tracker is found here: https://github.com/smeighan/xLights/issues

XLIGHTS/NUTCRACKER RELEASE NOTES:
--------------------------------
2016.12  Mar 10, 2016
    -- bug (dkulp) Fixed long save times when a model is off the screen.
    -- bug (dkulp) Fix corrupt perspective section. Fix is to Delete attribute before setting it
    -- bug (gil) Restore pause and stop for effect preview.

[Phrog30]

I'm seeing something weird that looks like it started in this latest release.  If I play the sequence, while it's playing the start button is disabled.  I thought it used to be where I could hit the play button while it was playing and it would start over from where it started.  Now, if I want to play again I have to hit stop, then start.  This isn't a big deal, just don't remember it being that way.  Also, if I'm playing the sequence then hit stop and select an effect, the play button disappears.  I have to hit stop, then hit play.  This definitely doesn't right to me.  I wanted to post here before I made a github ticket.

James

[Phrog30]

I'm seeing something weird that looks like it started in this latest release.  If I play the sequence, while it's playing the start button is disabled.  I thought it used to be where I could hit the play button while it was playing and it would start over from where it started.  Now, if I want to play again I have to hit stop, then start.  This isn't a big deal, just don't remember it being that way.  Also, if I'm playing the sequence then hit stop and select an effect, the play button disappears.  I have to hit stop, then hit play.  This definitely doesn't right to me.  I wanted to post here before I made a github ticket.

James

Github #493.  Also, attached a quick video, Github won't allow this file type.

James

[Gilrock]

Yep you're right.  Some of the audio changes done last month changed the operation of the buttons.  It was just a matter of Keith not knowing I was trying to make them operate like Audacity.  Sometimes the developers don't have all the history.  I know I stepped on some stuff when I first started helping.  He's added a lot of great work so I can't complain.

I thought I had caught and fixed the differences so thanks for finding this one.  I got it fixed and also I found some changes needed for animation sequences.

[Phrog30]

Didn't you also have it where the space bar would start and stop? If so, I think that may be broken as well. If not, then I must be thinking of something else and I apologize for bringing it up.

James

Sent from my SM-G900V using Tapatalk

[sean]

space bar works for me. press it , starts to play, press again it stops and resets pointer to start of song. This is how audacity treats the space bar.

The only other way a space bar works on some programs is first press starts to play, second press pauses, third press starts playing from last paused location. Maybe this would be better?
Space bar has worked for months as expected.
Remember we used Audacity as our template for action from buttons.
You also notice the loop does work. Highlight a section of song and press the loop button (two arrows facing each other) and the effect will loop forever

[Phrog30]

Strange, I just checked, some of my sequences the space bar won't work, others will. I will investigate further.

James

Sent from my SM-G900V using Tapatalk

[Phrog30]

I don't see a rhyme or reason, but the majority of my sequences the space bar has no effect. There is only a few sequences where the space bar works. I never really use the space bar, but thought this was interesting to share.

James

Sent from my SM-G900V using Tapatalk

[Phrog30]

I just created a new sequence with the latest version and the space bar doesn't work. So, I guess something was broken recently. Again, I don't use the space bar but was curious as to why Sean got it to work and I couldn't. Sean, can you try creating a new sequence and try the space bar?

James

Sent from my SM-G900V using Tapatalk

[Gilrock]

It's a focus issue.  Click in the waveform or grid area to set the focus and the spacebar will work.  It would be nice to fix it where the top level can catch the keystroke but we don't have that in place yet.

[Phrog30]

It's a focus issue.  Click in the waveform or grid area to set the focus and the spacebar will work.  It would be nice to fix it where the top level can catch the keystroke but we don't have that in place yet.

Dang, I feel like a dumb a...

Sorry about that. I thought I did that but obviously not. Oops.

James

Sent from my SM-G900V using Tapatalk

[plaberge]

The only other way a space bar works on some programs is first press starts to play, second press pauses, third press starts playing from last paused location. Maybe this would be better?

I would definitely prefer this. For me, the current action is pretty much a waste of the space bar. Typically when I sequencing, I am focused on a few seconds somewhere in the sequence. I rarely want to be playing from the beginning. It's not a huge deal, as it's easy to select what I want to play directly in the timeline.

[Gilrock]

The only other way a space bar works on some programs is first press starts to play, second press pauses, third press starts playing from last paused location. Maybe this would be better?

I would definitely prefer this. For me, the current action is pretty much a waste of the space bar. Typically when I sequencing, I am focused on a few seconds somewhere in the sequence. I rarely want to be playing from the beginning. It's not a huge deal, as it's easy to select what I want to play directly in the timeline.

I'm not sure what you're talking about because you can click in the waveform to set the start location.  It will be a black line.  When you hit the spacebar it will start playing from that black line it doesn't always go back to the start.  Only when you haven't set the start point.  It's designed to work like Audacity.  Focusing on a few seconds somewhere in the sequence works perfect now with the spacebar.  Set the start point and you can keep restarting playback from that point with the spacebar and hit it again to stop...again to start from that point again.  Perfect for replaying a section you're working on.