Author Topic: Model data checks  (Read 1548 times)

Offline AAH

  • Newbie
  • *
  • Posts: 30
    • View Profile
Model data checks
« on: December 16, 2017, 05:29:12 AM »
  I was editing a singing tree today based on a downloaded 1 and had all sorts of issues and I've seen others with similar ones.
  Could it be possible to do 2 checks on the model data
1) Check for non contiguous/sequential numbering and highlight the last/next numbers to indicate where the breaks are
2) Check  duplicate numbers and highlight duplicates

  Both of these could be handy for when typos are made as it's often hard to pick in a grid of hundreds of numbers where you've missed a number, had a typo which gives you a weird channel or ended up with a dupe. The check sequence may show up some of the issues but they can be exceptionally hard  to track down.
  Sometimes you want duplicate numbers and sometimes you want gaps in the channels so these "tools" would need to require user input.

Offline keithsw1111

  • Administrator
  • Hero Member
  • *****
  • Posts: 2733
    • View Profile
    • Kellyville Christmas Lights
Re: Model data checks
« Reply #1 on: December 17, 2017, 11:52:51 AM »
Both exist already.  Check sequence will complain about missing numbers and the wiring view will show both. Missing numbers result in discontinuities in the line and duplicates result in no line at all.

Check sequence will not highlight duplicates because it isn’t an error. If you were doing dumb lights it is exactly what you would do.

Offline AAH

  • Newbie
  • *
  • Posts: 30
    • View Profile
Re: Model data checks
« Reply #2 on: December 17, 2017, 02:14:40 PM »
Hi Keith
The wiring view shows me that there is an error but unfortunately in the case of the tree face xmodel that I have been playing with it still leaves me with no idea of where in the 80x80 grid containing 308 nodes where the issue is. The wiring view is good once you have no missing numbers but it doesn't help if you have unwanted missing channels or unwanted dupes.

Offline keithsw1111

  • Administrator
  • Hero Member
  • *****
  • Posts: 2733
    • View Profile
    • Kellyville Christmas Lights
Re: Model data checks
« Reply #3 on: December 17, 2017, 04:30:55 PM »
Check sequence will always help with missing numbers.

Duplicates is hard ... how do I know the duplicate is an error? Lots of custom models for ac/dumb rgb have them on purpose.

I could do a heuristic I guess .. if less than 5% of numbers are duplicated then assume they are errors?

Offline AAH

  • Newbie
  • *
  • Posts: 30
    • View Profile
Re: Model data checks
« Reply #4 on: December 17, 2017, 04:52:30 PM »
Hi Keith
The 2 issues are things that can be hard to pick up without a tool that is capable of processing them. I did some googling and it's possible to find dupes by exporting back to Excel and processing it.
Neither tool is a "1 tool fixes all" but if you've had a typo while laying something out you could easily find it.
I personally would prefer it as 2 radio buttons or similar so you could check for dupes and check for non contiguous separately. In both cases there will times where you've deliberately got breaks/dupes.

Offline keithsw1111

  • Administrator
  • Hero Member
  • *****
  • Posts: 2733
    • View Profile
    • Kellyville Christmas Lights
Re: Model data checks
« Reply #5 on: December 17, 2017, 05:53:13 PM »
It’s not going to be radio buttons. I don’t want the ui cluttered up any further. Check sequence is for these sorts of things.