Animated GIF crashes Program

[poporacer]

I am running 64 bit 2018.22 and trying to add an animated GIF to a Mega Tree. When I add the GIF, the program becomes unresponsive. I cannot exit the program, I have to use Task Manager to exit the program. If I render or try to save the sequence, it will start the process and then freeze up. I attached the GIF, Package files and a video showing the process. I think it might be the GIF but if there is a problem with the GIF, what is it, so I don't make another bad one?

[QldKing]

I was having a similar issue with a gif file where when viewing on the PC it looked fine but when it went into xlights one of the frames was corrupt. I believe he was able to view the issue and fix it in piskel editor

Dabil's 2017 Christmas Show Community WIP Thread
 https://r.tapatalk.com/shareLink?share_fid=81236&share_tid=4302&url=http%3A%2F%2Fnutcracker123%2Ecom%2Fforum%2Findex%2Ephp%3Ftopic%3D4302&share_type=t


Sent from my iPhone using Tapatalk

[keithsw1111]

This will be fixed in .23

[poporacer]

I don't know what a corrupt frame would look like, but I did open the image in Piskel and then save it with a new name and it doesn't crash the program any more.

[keithsw1111]

It’s not corrupt. It is just a very rare gif where the first frame is smaller than the largest frame in the gif.


Sent from my iPhone using Tapatalk

[cybi257]

I've had these issues before with the repository version. I would also get crashes when selecting fonts.

My resolution was simply compiling from source and those went away. Until....

The latest release, I had an issue with GIFImage.cpp failing to compile.

After changing:
_gifSize = wxSize(max(_gifSize.GetWidth(), its->GetWidth() + ito->x),
+                        max(_gifSize.GetHeight(), its->GetHeight() + ito->y));

to:

_gifSize = wxSize((_gifSize.GetWidth(), its->GetWidth() + ito->x),
+                        (_gifSize.GetHeight(), its->GetHeight() + ito->y));


I was able to successfully build it with out errors:

effects/GIFImage.cpp:131:88: error: ‘max’ cannot be used as a function
                     _gifSize = wxSize(max(_gifSize.GetWidth(), its->GetWidth() + ito->x),
                                                                                        ^
effects/GIFImage.cpp:132:76: error: ‘max’ cannot be used as a function
                         max(_gifSize.GetHeight(), its->GetHeight() + ito->y));


And so far, it seems that the Animated GIFs are doing OK on a couple of tests. Not sure what the max changes here from the coders intentions, but it is what it is and what allowed me to compile without errors and execute the program.

I should note that I pulled the code around 6pm PDT, which showed the last update was about 18 hours prior.

-Tim

EDIT : Running Linux -> Mint 19 Mate (Based on Ubuntu 18.04) and just a blurb that I thought may be useful?

[keithsw1111]

Removing max won’t help.


Sent from my iPhone using Tapatalk

[Gilrock]

Oh we need more of this.  If a standard function can't be found just delete it....lol.

[cybi257]

I'm not saying it's the right thing to do, but just experimenting with that, proved to allow it to compile without errors. I would like to know what it does, but I'm not asking for a programming lesson. lol.

Just merely showing what I did on the last compile that allowed me to complete and execute.

-Tim