XLights 2021.07 Crashes when attempting to Render Sequence

[gizmohd]

When attempting to render attached sequence.. XLights crashes out (Completely Exits).  Attached VS2019 debuger to the process when attempting it and get the following error:

Unhandled exception at 0x00007FF668F12506 in xLights.exe: 0xC0000005: Access violation reading location 0x00000000000001DC.

[dkulp]

It's crashing trying to deal with Christmas-Tree.ico.    We don't really do anything with ico files.   We assume the animations would be a gif.

[gizmohd]

Is this new?   This is one of my sequences I've used since 2017 and never had an issue with it before???  NO worries tho.. I've replaced it with a new image.. thanks for letting me know...

[dkulp]

I think the older wxWidgets just grabbed the first image in the ICO so it was treated as a single image.   The newer wxWidgets is saying there are 9 frames in the image so xLights is trying to decode it as an animation.   Anyway, I've updated the code so if decoding as an animated gif fails, it will just use the first image so it should work with the next release of xLights.

Also, while debugging your file, I noticed all the Single Strands on the Ground Props were taking forever.   Did some profiling on that and found a way to speed that up a bit as well.   Thanks for the test case!