Rotating Pictures

[Gilrock]

My pictures weren't lining up on the tree correctly so I needed to be able to rotate them.  I added an X-axis Center slider to the Pictures effect which made it easy to place the picture how I want it.  Here's a quick video of me placing Olaf on my pixel tree and showing how the slider will rotate him.
https://www.youtube.com/watch?v=vkauL2IKCv0

I'd like to know how to determine if changes I do are desired for the main build and how you all coordinate accepting in new changes.  If this is something desirable I'll get it updated so it works for all the Movement settings.  For this test I just implemented it into the None setting for a static picture.

[mitch09]

That's awesome!  I needed that when sequencing my last song.

Ryan

[colonelcline]

Would be much better than adding blank space above or below a picture to get it right on the tree.

[Gilrock]

Well I'd love to start trying to get some of my changes included in the build but none of the developers are responding to me.

[sean]

What is your github I'd? I'll add u as a developer. I will also add u to email list of developers. The process is make sure u pull the latest code (sometimes there are 3-4 updates per day), make your changes, test and then post changes back to main. Then send an email to developers. I then pull an do more testing. Also update the README.txt with the release notes. Make these notes dearer to a non-technical audience. I usually do 1-2 releases per week. I am the config management and the release management. X,y sliders would not be needed on effects like colorwash and twinkle, but most other effects could use them. I wanted to move the x,y sliders from the ripple effect and put into the palette,speed frame since it would be nice on every effect. Thanks and welcome

[Gilrock]

My github ID is AzGilrock.  I was just reading more about how to use GitHub.  After reading it I thought I should make a fork and then do a Pull Request but your saying you just check things back into main?

For this rotation change I have code that keeps it from truncating the picture if the calculated x value for the pixel is negative.  I changed it so the truncated section would wrap around to the higher number strings so when you drag it to the edge of column 1 it wrapped instead of looking like it was disappearing.  But I realized this really only applies to something circular like a tree so it may need a checkbox to enable/disable the wrapping because on a flat matrix you might not want anything scrolling off the left side to show up on the right side.

I know most of my changes are simple but I mainly wanted to show I can help out.  I noticed there is whitespace in front of the LMS choice when selecting the filetype on the convert screen so I fixed that on my version.

I also like to have the WS_LABELS flag set on the X and Y sliders for the Pinwheel because it lets you see the value you land on when moving the slider and gets the number in your head for next time you use it.
 

[sean]

Was-labels causes two problems. It uses more screen space reducing the size of the grid. No issue on desktops, but a problem on laptop display.s the second issue is when u autocreate effects, u normally go through the grid using down arrow. U can preview effects a couple per second this way. If an effect has ws_labels then the down arrow starts moving slider bars. I consider this a bug in wxwidgets but I removed my ws_labels because of it.

U can go ahead and make a branch to work. Pull from main to make sure your code still works and then let me know and I'll merge from your branch. Most of us are pulling and posting directly to the main branch.

[Gilrock]

Ok I won't use the ws_labels but the main goal was I wanted to see the value to easily duplicated how far I rotated it so when I insert a similar effect in another sequence I would know what my normal rotation number should be.  Maybe a text field beside it that updates to the current value.  I didn't think about the screen space.  My desktop has a huge 30" monitor so it looked like there was tons of space without affecting the grid.  So what would be the target resolution for a typical laptop?  I could configure one that way so I can preview how changes look.

[sean]

Gilrock; you are now added as a collaborator on xlights.
send an email to me at sean@meighan.net and i will add you to the list of developers

thanks
sean