Author Topic: Saving Sequences  (Read 3946 times)

Offline Charles Belcher

  • Full Member
  • ***
  • Posts: 164
    • View Profile
Saving Sequences
« on: August 31, 2015, 05:41:33 PM »
When closing a sequence you are presented with a dialog box titled,
"Sequence Changed Confirmation" and dialog that states, "Sequence changes will be lost.  Do you wish to continue?"  Yes No

If I wanted to save and clicked Yes, then all is good.  If I did not want to save and clicked No, then all is good.

If I wanted to save, but accidentally hit Yes, then my changes are lost.  If I hit No, then I am taken back to the open sequence and I can try again.
__________________________________

How about a line that states, "Sequence has changed, do you wish to save it before closing?" Yes No

If Yes, then xLights auto saves. If No, then a new dialog pops up which asks, "Are you sure you want to close the sequence without saving changes?" Yes No

If Yes, then xLights closes the sequence.  If No, then you are returned to the original question.

Charles



« Last Edit: August 31, 2015, 09:07:24 PM by Charles Belcher »
2014 Finalist The Great Christmas Light Fight
2018 All Star The Great Christmas Light Fight

Offline kevinp

  • Sr. Member
  • ****
  • Posts: 373
    • View Profile
Re: Saving Sequences
« Reply #1 on: August 31, 2015, 06:24:02 PM »
I'd open a GitHub ticket on this subject as your request makes sense to me and I'd think is an easy change to implement.
Kevin Pankratz
Blaine MN

Offline Gilrock

  • Supporting Member
  • Hero Member
  • *
  • Posts: 6946
    • View Profile
Re: Saving Sequences
« Reply #2 on: September 01, 2015, 07:19:11 AM »
I don't like that idea.  We would be switching the meaning of Yes and people's brains already have it registered what that does.  I have a better idea but I'll keep it to myself till I check it in.  Less room for people to complain about it that way.

Offline gerry

  • Hero Member
  • *****
  • Posts: 695
    • View Profile
Re: Saving Sequences
« Reply #3 on: September 01, 2015, 04:59:24 PM »
IMHO , as long as there is some prompt/warning  about losing ones work , we should be happy and work with it.
A short while ago, there was no prompt , then the default was the wrong one ..... :)

There is though an inconsistency between the Seq save message and the View save message ... but if  either of the messages  pop up , it should be viewed seriously (IMO).
Gerry

Offline Gilrock

  • Supporting Member
  • Hero Member
  • *
  • Posts: 6946
    • View Profile
Re: Saving Sequences
« Reply #4 on: September 01, 2015, 11:01:43 PM »
Alright I'll tell you my idea.  I think it would be best to show a message with 3 buttons "Save Sequence", "Discard Changes", "Cancel".  That way you really don't need to read the message....you just read the button.

Offline RoboMello

  • Full Member
  • ***
  • Posts: 105
    • View Profile
Re: Saving Sequences
« Reply #5 on: September 01, 2015, 11:11:47 PM »
Ok, since we are talking about save, try this.
Open xLights, then open any sequence, now close that sequence, now by mistake instead of clicking the Open Sequence Icon, you click on Save.
xLights crashes every time.
I am not saying that I do that very often, that would be stupid :-(, oh wait I might be stupid.

Offline Gilrock

  • Supporting Member
  • Hero Member
  • *
  • Posts: 6946
    • View Profile
Re: Saving Sequences
« Reply #6 on: September 01, 2015, 11:21:19 PM »
Yeah after you close the sequence it turns into the Save Bug Report button....lol.

Offline gerry

  • Hero Member
  • *****
  • Posts: 695
    • View Profile
Re: Saving Sequences
« Reply #7 on: September 02, 2015, 12:50:49 AM »
Alright I'll tell you my idea.  I think it would be best to show a message with 3 buttons "Save Sequence", "Discard Changes", "Cancel".  That way you really don't need to read the message....you just read the button.

Default (if u press enter) is Save Sequence I hope ?

In which case am happy ... but am happy now too :)
Gerry

Offline Gilrock

  • Supporting Member
  • Hero Member
  • *
  • Posts: 6946
    • View Profile
Re: Saving Sequences
« Reply #8 on: September 06, 2015, 07:02:10 PM »
Ok here's what I have checked in for a new Save Changes prompt if anyone wants to say anything about it before it goes live:


Offline sean

  • Administrator
  • Hero Member
  • *****
  • Posts: 1727
    • View Profile
    • Xlights and Nutcracker Forum
Re: Saving Sequences
« Reply #9 on: September 06, 2015, 07:05:48 PM »
Seems clearer gil


Sent from my iPhone using Tapatalk
Sean
Littleton, CO
Latest releases http://nutcracker123.com/nutcracker/releases
xLights/Nutcracker Forum http://nutcracker123.com/forum/index.php
Fbook [url=https://www.facebook.com/groups/62

Offline Phrog30

  • Hero Member
  • *****
  • Posts: 1234
    • View Profile
Re: Saving Sequences
« Reply #10 on: September 06, 2015, 07:08:31 PM »
Ok here's what I have checked in for a new Save Changes prompt if anyone wants to say anything about it before it goes live:


Seems pretty clear.

Offline jnealand

  • Hero Member
  • *****
  • Posts: 1421
    • View Profile
Re: Saving Sequences
« Reply #11 on: September 06, 2015, 07:28:22 PM »
I like it!!!
Jim Nealand
Kennesaw, GA

Offline logandc99

  • Sr. Member
  • ****
  • Posts: 257
    • View Profile
Re: Saving Sequences
« Reply #12 on: September 06, 2015, 07:47:16 PM »

Offline flyinverted

  • Administrator
  • Hero Member
  • *****
  • Posts: 756
    • View Profile
Re: Saving Sequences
« Reply #13 on: September 06, 2015, 08:21:19 PM »
The middle text is redundant to me since the buttons are clearly labeled.  The rest is good.


« Last Edit: September 06, 2015, 09:57:31 PM by flyinverted »
Steve Giron
Maricopa County, AZ
xLights user with a boat-load of channels.

Do not ask to know all the answers, but ask to understand the question.

Offline Charles Belcher

  • Full Member
  • ***
  • Posts: 164
    • View Profile
Re: Saving Sequences
« Reply #14 on: September 06, 2015, 11:19:40 PM »
What dialog do you receive if you open a sequence and close it without doing anything?
2014 Finalist The Great Christmas Light Fight
2018 All Star The Great Christmas Light Fight