Docking Issue in Sequencer & various oddities

[robskimeister]

Here are a few more thing I've found in 2016.16:

When I'm in the sequencer tab and I have an effect highlighted (turns purple):  If I un-dock and try to re-dock the House Preview window, I'm unable to dock the window while the effect is highlighted .  The "docking shadow" appears, but the window won't dock there.

If I place the House Preview somewhere so that part of the window is off-screen (while the effect is still highlighted) and click Render All, it seems to lock up & just sits there "forever" with all the icons greyed out.  If I try to exit Xlights during this time by clicking "X" in the top right corner, I get a crash.  I've attached the debug/crash files.

Also, if I un-highlight the effect I'm able to dock the window again, but things seem wonky afterwards.  For instance if I click FILE --> OPEN SEQUENCE immediately after docking the window, nothing happens. If I click some things in the sequencer & then try to do FILE --> OPEN SEQUENCE again, it works.  Weird.

One more thing: in the attached sequence (Testing.xml), when I click the + and - icons a few times to zoom in & out, sometimes I get some crazy large numbers (over 7000) at the top when I click the - icon.  I've attached 2 pictures showing these.

Hopefully you'll be able to duplicate these issues.
Please let me know if you need any additional information.

Thanks again for the help! 

[robskimeister]

One more thing I just noticed in 2016.17: 

When I delete an effect in the Sequencer tab by highlighting it & pressing DELETE, it copies the deleted effect to the clipboard and overwrites whatever was previously stored there.  Basically it's acting as if I pressed CTRL-X.

Then the next time I paste something using CTRL-C, it pastes the deleted effect.

[Gilrock]

One more thing I just noticed in 2016.17: 

When I delete an effect in the Sequencer tab by highlighting it & pressing DELETE, it copies the deleted effect to the clipboard and overwrites whatever was previously stored there.  Basically it's acting as if I pressed CTRL-X.

Then the next time I paste something using CTRL-C, it pastes the deleted effect.

That sounds like how I wrote it.  At first we didn't even have CTRL-X.  When I added it I just had it call the same delete code.

[robskimeister]

That sounds like how I wrote it.  At first we didn't even have CTRL-X.  When I added it I just had it call the same delete code.

Yes I absolutely love having CTRL-X, CTRL-C and CTRL-V!  Thank you for that!      

...but shouldn't delete & CTRL-X be 2 distinct operations?  When a user deletes something, it's because they don't want it any more...  they want it GONE.

However, when a user "cuts" something (CTRL-X) it's because they want to save it & move it somewhere else.

This isn't a huge deal, but it's just counter-intuitive from every other editor I've ever used. 

Also, it could possibly result in users losing effects that they thought they had saved in the clipboard.  This actually happened to me earlier:  I pressed CTRL-X to cut an effect.  I deleted an unwanted effect to make room.  Then I attempted to paste the effect that I had previously cut, and it was GONE!    I guess undo comes in handy for situations like that!

[Gilrock]

I checked the source code.  The way I coded everything is how you expected it to work.  Delete should only be deleting and not copying.  The CTRL-X operation does do a copy and then delete.  Another developer recently updated my code so that if you are on Windows holding down a Shift key while hitting the Delete key it's supposed to do a Cut instead of a Delete.  The way you're describing it the code is reacting as if it thinks the Shift key is pressed.  I've never tested the code changes he did so I'll have to check on that soon.