« previous next »
Pages: [1] 2   Go Down

Author Topic: Bug in .19 and above with "Text" effect, Color red  (Read 2341 times)

Offline brichi

  • Full Member
  • ***
  • Posts: 113
    • View Profile
Bug in .19 and above with "Text" effect, Color red
« on: July 29, 2018, 08:52:30 AM »
Bug in "Text"effect when using red in .19 and higher on Mac.

If I set a test scrolling text red in .18 it plays as it should, if I switch to .19 or higher the red looks fine in the preview but its outputting orange to the pixels, not red. If I use other effects like bars and such then red is red on pixels but once I switch to text effect, red outputs orange.

I found a setting in the text area if you choose your own size custom font like arial and the "XL FONT" dropdown says "USE OS FONTS" that's when I get orange from red BUT if I choose a XL FONT preset and don't use OS fonts, then its red. I am also on Mojave so I wonder if thats part of it too.

here's one video I made for Keith to show - https://www.youtube.com/watch?v=oqGlAZB3TUk

heres another too I posted on FB group - https://www.facebook.com/brian.chiaino/videos/10214820748465063/
« Last Edit: July 29, 2018, 04:26:45 PM by brichi »
Logged

Offline keithsw1111

  • Administrator
  • Hero Member
  • *****
  • Posts: 2733
    • View Profile
    • Kellyville Christmas Lights
Re: Bub in .19 and above with "Text" effect, Color red
« Reply #1 on: July 29, 2018, 04:24:15 PM »
My tests on windows don’t reproduce the problem. Could it be an OS X font related issue?


Sent from my iPhone using Tapatalk
Logged

Offline Gilrock

  • Supporting Member
  • Hero Member
  • *
  • Posts: 6946
    • View Profile
Re: Bug in .19 and above with "Text" effect, Color red
« Reply #2 on: July 29, 2018, 06:23:09 PM »
Brichi the "XL Fonts" were bitmap fonts I created so the fonts giving you a problem are the ones that have been in the program forever.
Logged

Offline brichi

  • Full Member
  • ***
  • Posts: 113
    • View Profile
Re: Bug in .19 and above with "Text" effect, Color red
« Reply #3 on: July 29, 2018, 06:25:39 PM »
Quote from: Gilrock on July 29, 2018, 06:23:09 PM
Brichi the "XL Fonts" were bitmap fonts I created so the fonts giving you a problem are the ones that have been in the program forever.

Hi Gil, the fonts giving me the issue is when I choose "use OS Fonts". they work fine in .19 but anything after .19 the red is outputted as orange. Tested on 2 separate Macs and have the same results so something in .20 and higher doesn't like something using red OS Fonts
« Last Edit: July 29, 2018, 06:27:30 PM by brichi »
Logged

Offline Gilrock

  • Supporting Member
  • Hero Member
  • *
  • Posts: 6946
    • View Profile
Re: Bug in .19 and above with "Text" effect, Color red
« Reply #4 on: July 29, 2018, 06:46:57 PM »
I'm just telling you about the XL fonts.  By the way you aren't supposed to mess with the color of the Font where you were doing it.  The color is supposed to come from the swatch you select on the Color Panel in xLights.
Logged

Offline brichi

  • Full Member
  • ***
  • Posts: 113
    • View Profile
Re: Bug in .19 and above with "Text" effect, Color red
« Reply #5 on: July 29, 2018, 06:49:46 PM »
Quote from: Gilrock on July 29, 2018, 06:46:57 PM
I'm just telling you about the XL fonts.  By the way you aren't supposed to mess with the color of the Font where you were doing it.  The color is supposed to come from the swatch you select on the Color Panel in xLights.

I only went into there to see if it made a difference as a test. using all the same settings, just opening .19 makes the scrolling matrix red so theres definitely something up with a change from .19 to .20. Is there anything I can supply you guys with to test? it seems to be a Mac only issue so not sure who can really test this. also if I go into any other effect the red works properly, its only on the text effect using os fonts
« Last Edit: July 29, 2018, 06:51:38 PM by brichi »
Logged

Offline Gilrock

  • Supporting Member
  • Hero Member
  • *
  • Posts: 6946
    • View Profile
Re: Bug in .19 and above with "Text" effect, Color red
« Reply #6 on: July 30, 2018, 08:31:24 AM »
There was only 6 checkins between .19 and .20.  Curiously there is a checking that makes a Text control background red if the field is empty change that was done.
https://github.com/smeighan/xLights/commit/759414cf11fb38a91735d805d588e72617bcd981
Logged

Offline Gilrock

  • Supporting Member
  • Hero Member
  • *
  • Posts: 6946
    • View Profile
Re: Bug in .19 and above with "Text" effect, Color red
« Reply #7 on: July 30, 2018, 08:32:23 AM »
There were a few submodel changes in that release.  Does the model you are putting text on have Submodels?
Logged

Offline brichi

  • Full Member
  • ***
  • Posts: 113
    • View Profile
Re: Bug in .19 and above with "Text" effect, Color red
« Reply #8 on: July 30, 2018, 08:41:17 AM »
Quote from: Gilrock on July 30, 2018, 08:32:23 AM
There were a few submodel changes in that release.  Does the model you are putting text on have Submodels?

Hey Gil, there was no submodels, I opened up a brand new install of xlights, added a matrix quick and dropped on some text using the OS font of my choice
Logged

Offline Gilrock

  • Supporting Member
  • Hero Member
  • *
  • Posts: 6946
    • View Profile
Re: Bug in .19 and above with "Text" effect, Color red
« Reply #9 on: July 30, 2018, 08:53:02 AM »
So if you go back to .19 the issue goes away?  And what is happening with green or blue?
Logged

Offline brichi

  • Full Member
  • ***
  • Posts: 113
    • View Profile
Re: Bug in .19 and above with "Text" effect, Color red
« Reply #10 on: July 30, 2018, 08:54:41 AM »
Quote from: Gilrock on July 30, 2018, 08:53:02 AM
So if you go back to .19 the issue goes away?  And what is happening with green or blue?

correct, if I go to .19 the issue goes away

green and blue work perfect on all versions. just the red is the issue on .20 and above
Logged

Offline dkulp

  • Supporting Member
  • Hero Member
  • *
  • Posts: 812
    • View Profile
Re: Bug in .19 and above with "Text" effect, Color red
« Reply #11 on: July 30, 2018, 10:22:05 AM »

Tracked this down to a change in wxWidgets:

https://github.com/wxWidgets/wxWidgets/commit/24dbe9775c1901b24a514ead28923227922b30af

They moved from a generic RGB color space to an SRGB color space.   Thus, colors are getting mapped funky.   It's trivial to rebuild wxWidgets with the old color space, but then parts of the UI (particularly dark mode things) don't look correct in Mojave as Mojave uses SRGB for display on any monitor that can handle it.  (any recent Mac)
Logged
Daniel Kulp
Framingham, MA

Offline Gilrock

  • Supporting Member
  • Hero Member
  • *
  • Posts: 6946
    • View Profile
Re: Bug in .19 and above with "Text" effect, Color red
« Reply #12 on: July 30, 2018, 10:28:05 AM »
Cool...thanks for tracking that down.  I had just reviewed the checkin's again and was about to post I couldn't see any way that those checkins caused a difference.
Logged

Offline dkulp

  • Supporting Member
  • Hero Member
  • *
  • Posts: 812
    • View Profile
Re: Bug in .19 and above with "Text" effect, Color red
« Reply #13 on: July 30, 2018, 10:33:32 AM »

Most likely, this affects the Text and Tendrils effects as those use some of the native drawing routines that are affected by color spaces.
Logged
Daniel Kulp
Framingham, MA

Offline brichi

  • Full Member
  • ***
  • Posts: 113
    • View Profile
Re: Bug in .19 and above with "Text" effect, Color red
« Reply #14 on: July 30, 2018, 12:42:22 PM »
Quote from: dkulp on July 30, 2018, 10:33:32 AM

Most likely, this affects the Text and Tendrils effects as those use some of the native drawing routines that are affected by color spaces.

glad you saw something with it Dan, thank you guys, please let me know if theres anything I can test out for ya
Logged
Pages: [1] 2   Go Up
« previous next »