Conversion For LOR S5 Sequences

[Gilrock]

Could someone write an S5 importer?  Maybe...I haven't really looked at the loredit format.  It will take a developer having interest in doing that.   Problem is xLights was well established when LOR S5 came out so none of us have a need to convert S5 data.  Back when we first started we all had Vixen 2.5, LOR LMS files, LightShowPro, and HLS files that we needed to get into xLights so those importers got developed.  If we were a company that sold this as a product there would be a different motivation for adding new features.  With freeware you need to find a developer that wants to work on it.

[Tazcowboy]

I completely understand. That’s why I was asking what the process would was for asking for this type of enhancement. I understand that X lights is open source and only income is donations.

I’m hoping there is the interest from others on this subject as there there could be others like me that want to convert from S5 to Xlights like me without loosing there LOR efforts

I would be happy to assist with any developer that wants to work on this. I can provide samples and test.  I am am not a developer, but work as a systems analyst ,business analyst and QA software when I am not playing with my lights.


Sent from my iPad using Tapatalk

[keithsw1111]

I wrote the lpe import and would consider doing s5 if I got substantial help from someone like yourself. Challenge is as ever priority and right now I am tied up on other items.


Sent from my iPhone using Tapatalk

[Tazcowboy]

Great.... I may be wrong, but I feel somehow in S5 import PROCESS will be a combination of the old LMS and the LPE code that’s already done.  In the LOREDIT file I see a prop defined as a GUID.  And then later the prop is sequenced. That’s the only research I’ve had so far.

I will continue to try to look at the layout and contents of the new newer LOREDIT file to see if I can find a pattern.

I will do what I can when you have the time.  Please let me know what I can do.   Many Thanks. 


Sent from my iPhone using Tapatalk

[keithsw1111]

Start by sending me a sample loredit file.


Sent from my iPhone using Tapatalk

[Tazcowboy]

LOR S5 was a big change from all there previous releases.  Much like Xlights it now used a layout, they call it a preview.  For those of us the used the Visualizer in LOR, it “sort da” imported, but there was big effort to have create this to use S5.  I mention this because I believe the preview data is part of the LOREDIT file.
Here is a screen shot of the my Halloween 2018 Preview.

**S5 preview.PNG**

In the LOREDIT XML I see a sections named PreviewClass, this is where I think the data is stored for the preview.  And in the section there is a PropClass section for each prop.  In the screen shot I have Inflatable Pumpkin 8 selected.   And here is what I think the corresponding XML is:

<PropClass id="e490af01-acb8-469b-a75c-ef5d55151346" BulbShape="Pentagon" ChannelGrid="Regular,06,8,8,0," Comment="" CustomBulbColor="FFFFFF80" DeviceType="LOR" DimmingCurveName="None" IndividualChannels="True" MaxChannels="512" Opacity="255" PreviewBulbSize="24" RgbOrder="RGB order" MasterPropId="" SeparateIds="False" StartLocation="n/a" StringType="Traditional" TraditionalColors="Red" TraditionalType="Channel_per_color" EffectBulbSize="2" Name="Inflatable Pumpkin 8" Parm1="1">
      <shape ShapeName="Bulbs"> <point x="-0.4767568" y="-0.3434343" />
      </shape>
</PropClass>
 
Then later on in the XML I see the ID Guid  in a PropGroup Section that matches up with the Inflatables Group (it’s the blue text, groups were identified by blue):

  <PropGroup id="489caf9f-92da-4fa9-8d79-322c07f9aa27" Arrangement="Preview" PreviewResFactor="1" EffectBulbSize="1" Name="Infateables">
      <member id="652e2e7a-c39a-431b-a0b8-976fed7ffe80" orientation="normal" />
      <member id="c969b087-9c25-4397-b873-d795dbba23c8" orientation="normal" />
      <member id="8a02d079-fc4f-410b-a0a0-5e2e44e87662" orientation="normal" />
      <member id="530069fe-62cc-4862-a12f-a2f1fe8f142f" orientation="normal" />
      <member id="9e61342a-ca46-4695-8eb6-6734eb91422f" orientation="normal" />
      <member id="f6985faa-652b-49ef-a4b8-eaecf45523fa" orientation="normal" />
      <member id="35e4c5d0-cc81-4add-9dd7-91bee5b7fa9c" orientation="normal" />
      <member id="e490af01-acb8-469b-a75c-ef5d55151346" orientation="normal" />
    </PropGroup>

I also see that Prop ID Guid in the SeqProp section.  This reminds me of the S4 layout:

<SeqProp id="e490af01-acb8-469b-a75c-ef5d55151346" name="Inflatable Pumpkin 8" EnablePixelChannels="0">
<channel row="0" col="0" color="0">
<effect startCentisecond="3908" endCentisecond="3964" intensity="100" settings="INTENSITY" />
<effect startCentisecond="6470" endCentisecond="6518" intensity="100" settings="INTENSITY" />
<effect startCentisecond="6518" endCentisecond="6619" startIntensity="100" endIntensity="0" settings="INTENSITY" />
<effect startCentisecond="10047" endCentisecond="10251" startIntensity="0" endIntensity="100" settings="INTENSITY" />
<effect startCentisecond="10251" endCentisecond="10351" intensity="100" settings="TWINKLE" />
<effect startCentisecond="10351" endCentisecond="10373" intensity="100" settings="INTENSITY" />
<effect startCentisecond="10373" endCentisecond="10398" startIntensity="100" endIntensity="0" settings="INTENSITY" />
<effect startCentisecond="15033" endCentisecond="15057" startIntensity="100" endIntensity="0" settings="INTENSITY" />
<effect startCentisecond="15057" endCentisecond="15081" intensity="100" settings="INTENSITY" />
<effect startCentisecond="15081" endCentisecond="15181" intensity="100" settings="SHIMMER" />
<effect startCentisecond="15181" endCentisecond="15205" startIntensity="100" endIntensity="0" settings="INTENSITY" />
<effect startCentisecond="15205" endCentisecond="15230" intensity="100" settings="INTENSITY" />
<effect startCentisecond="15230" endCentisecond="15254" startIntensity="100" endIntensity="0" settings="INTENSITY" />
<effect startCentisecond="15254" endCentisecond="15380" startIntensity="100" endIntensity="0" settings="INTENSITY" />
<effect startCentisecond="15380" endCentisecond="15427" startIntensity="100" endIntensity="4" settings="INTENSITY" />
<effect startCentisecond="15427" endCentisecond="15479" startIntensity="100" endIntensity="0" settings="INTENSITY" />
<effect startCentisecond="15479" endCentisecond="15578" startIntensity="0" endIntensity="100" settings="INTENSITY" />
<effect startCentisecond="15578" endCentisecond="15652" startIntensity="100" endIntensity="70" settings="INTENSITY" />
<effect startCentisecond="15676" endCentisecond="15802" startIntensity="61" endIntensity="10" settings="INTENSITY" />
</channel>
</SeqProp>

There a ViewMember group that must be part of what used in the Sequencer to set up views (use to be tracks in S4),  The Prop Id Guid is in that section a few times but with a different category.

I am showing what I think matches up with this screen shot.

**S5 seg.PNG**
 
<ViewMember id="LOR Unit 6" category="GridView_Group">
        <ViewMember id="652e2e7a-c39a-431b-a0b8-976fed7ffe80/0-0-0" category="Event_Collection" />
        <ViewMember id="c969b087-9c25-4397-b873-d795dbba23c8/0-0-0" category="Event_Collection" />
        <ViewMember id="8a02d079-fc4f-410b-a0a0-5e2e44e87662/0-0-0" category="Event_Collection" />
        <ViewMember id="530069fe-62cc-4862-a12f-a2f1fe8f142f/0-0-0" category="Event_Collection" />
        <ViewMember id="9e61342a-ca46-4695-8eb6-6734eb91422f/0-0-0" category="Event_Collection" />
        <ViewMember id="f6985faa-652b-49ef-a4b8-eaecf45523fa/0-0-0" category="Event_Collection" />
        <ViewMember id="35e4c5d0-cc81-4add-9dd7-91bee5b7fa9c/0-0-0" category="Event_Collection" />
        <ViewMember id="e490af01-acb8-469b-a75c-ef5d55151346/0-0-0" category="Event_Collection" />
        <ViewMember id="622b6072-938d-466d-86ab-df5686502dfd/0-0-0" category="Event_Collection" />
        <ViewMember id="50044201-a241-450f-9c9f-699c2e0bfcaf/0-0-0" category="Event_Collection" />
        <ViewMember id="633e1570-db7a-465c-bd53-72129ff62797/0-0-0" category="Event_Collection" />
        <ViewMember id="d18489f1-0a8c-4ffe-b6a8-188e40491104/0-0-0" category="Event_Collection" />
        <ViewMember id="796b3bb9-7e5f-4dd0-8084-5c76b655f1d9/0-0-0" category="Event_Collection" />
        <ViewMember id="8c2a32a7-cbfb-4633-afb3-a29b9f4dd37b/0-0-0" category="Event_Collection" />
        <ViewMember id="c93a958c-2d16-4121-a677-b87e77151111/0-0-0" category="Event_Collection" />
        <ViewMember id="9ce4b761-8244-4990-a309-a007827328cd/0-0-0" category="Event_Collection" />
      </ViewMember>


The prop named 4K garage was a prop built new in S5:

<PropClass id="8f165030-c39a-4bd8-8b89-02f892e84ae9" BulbShape="Square" ChannelGrid="Regular,118,1,408,0,;Regular,118,409,510,306,;Regular,119,307,510,204,;Regular,120,205,510,102,;Regular,121,103,510,0,;Regular,122,1,408,0,;Regular,122,409,510,306,;Regular,123,307,510,204,;Regular,124,205,510,102,;Regular,125,103,510,0,;Regular,126,1,408,0,;Regular,126,409,510,306,;Regular,127,307,510,204,;Regular,128,205,510,102,;Regular,129,103,510,0,;Regular,130,1,408,0,;Regular,130,409,510,306,;Regular,131,307,510,204,;Regular,132,205,510,102,;Regular,133,103,510,0,;Regular,134,1,408,0,;Regular,134,409,510,306,;Regular,135,307,510,204," Comment="" CustomBulbColor="FFFFFF80" DeviceType="DMX" DimmingCurveName="LinearCurve 70%" IndividualChannels="True" MaxChannels="510" Opacity="255" PreviewBulbSize="2" RgbOrder="RGB order" MasterPropId="" SeparateIds="False" StartLocation="Bottom Right" StringType="RGB" TraditionalColors="" TraditionalType="Multicolor_string_1_ch" EffectBulbSize="1" Name="4K garage door" Parm1="23" Parm2="136" Parm3="0">
     
      <shape ShapeName="Matrix-Horizontal-Rectangle" OffsetX="-0.2067217" OffsetY="-0.1334783" ScaleX="0.3022235" ScaleY="0.3042751" Radians="0" />

</PropClass>

And this will only have S5 Pixel Editor effects on it.  Only two effect were on used, the fire effect and a image was scrolled from top to bottom.  This is what I think the LPE file logic would be used on. 

Let me know if you have any questions

[Gilrock]

I looked at that loredit file.  The problem is I do not see 2 effects like you said it should only be a fire effect and picture effect.  I see thousands of tiny intensity effects.  That's like the effects have already been converted to data so each and every cell is its own effect in that file.  That's what has always made LOR less efficient.  You have a file that is 29MB to represent mainly just 2 effects.  Sure we could probably write a parser that will bring that in as thousands of tiny On effects but its really not worth it performance wise.  Having that many effects makes the performance of xLights suffer and you will not have as good of an experience using the program as you should have.  I think you need to decide if you want to stick with LOR or start your sequences over in xLights.  I eventually threw away all my LOR sequences so I've been there.

[keithsw1111]

So I spent some time looking over this file and it is interesting on several levels.

Its stunning how little it has changed. I was under the impression S5 was big and new but that file is just a mix of an LMS and LPE file ... the settings themselves seem little changed.

But it also isnt the same as the old files so it needed a new import which I also wrote differently.

It is pretty much guaranteed not to work first time as all i have is one sample file and no copy of S5 to test with ... but for what its worth it will be in .17.

If you really want to help you will test and produce simple examples of problems and send them to me so i can fix any issues.

[Tazcowboy]

I looked at that loredit file.  The problem is I do not see 2 effects like you said it should only be a fire effect and picture effect.  I see thousands of tiny intensity effects.  That's like the effects have already been converted to data so each and every cell is its own effect in that file.  That's what has always made LOR less efficient.  You have a file that is 29MB to represent mainly just 2 effects.  Sure we could probably write a parser that will bring that in as thousands of tiny On effects but its really not worth it performance wise.  Having that many effects makes the performance of xLights suffer and you will not have as good of an experience using the program as you should have.  I think you need to decide if you want to stick with LOR or start your sequences over in xLights.  I eventually threw away all my LOR sequences so I've been there.

To Clarify, there are lots of “old school” rgb effects in that file.  Before LOR had a pixel editor I use 3 party tools to create effects for props that basically broke it down to tiny effects to each color channel in a clip board.  (Not that I understand the programming behind that ).   The fire and pic scroll was to show one example of something I did in S5.  Most of those thousands of lines were old school before LOR pixel editor.


Sent from my iPhone using Tapatalk

[Tazcowboy]

So I spent some time looking over this file and it is interesting on several levels.

Its stunning how little it has changed. I was under the impression S5 was big and new but that file is just a mix of an LMS and LPE file ... the settings themselves seem little changed.

But it also isnt the same as the old files so it needed a new import which I also wrote differently.

It is pretty much guaranteed not to work first time as all i have is one sample file and no copy of S5 to test with ... but for what its worth it will be in .17.

If you really want to help you will test and produce simple examples of problems and send them to me so i can fix any issues.

Yes.  I will test a bunch of my LOREDIT files to see what results it produces to xLights and let you know.



Sent from my iPhone using Tapatalk

[Tazcowboy]

When mapping my props from S5 to my existing models in xLights there were 56 props were missing.  I am attaching and XML files of the <PropClass> tags that were not available for mapping.  I could not find any pattern.  Some were RGB while others were AC props.  Let me know there is any additional information or research on this issue. 

[Tazcowboy]

I have nine props when mapped cause xLights to crash.  One thing unique is that I noticed there are nine times  is a group when listed in alphabetical order in the mapping lists (see screen shot).  Inflatable Pumpkin 1,2,3,4,5,6,7,8 and Lamp Post cause the crash. 

I have attached the crash dump when just mapping the Lamp Post prop.

[Tazcowboy]

When the import is complete the only effects I see are on the 4Kgarage door model.  That prop was sequenced in S5 with Pixel Editor.  It was a fire effect on a matrix, and a graphic scrolling down.  The timings were good, but would need fine tuning to match what I had in LOR.  The fire was set to a lower height and the speed of the graphic needed changing.  But I was expecting that. 

Not sure why none of the other sequencing effects came over.  I didn't receive any errors during the import.   
To me it looked like the LPE logic worked, but the LMS code wasn’t working.   I don’t have any other props there were only created with the Pixel Editor in S5 test with until 2019.18 LOREDIT Import – Issue one is addressed.   

Let me know if there is any specific scenario you would want me to create in S5 for me to test and review for this issue. 

[keithsw1111]

When the import is complete the only effects I see are on the 4Kgarage door model.  That prop was sequenced in S5 with Pixel Editor.  It was a fire effect on a matrix, and a graphic scrolling down.  The timings were good, but would need fine tuning to match what I had in LOR.  The fire was set to a lower height and the speed of the graphic needed changing.  But I was expecting that. 

Not sure why none of the other sequencing effects came over.  I didn't receive any errors during the import.   
To me it looked like the LPE logic worked, but the LMS code wasn’t working.   I don’t have any other props there were only created with the Pixel Editor in S5 test with until 2019.18 LOREDIT Import – Issue one is addressed.   

Let me know if there is any specific scenario you would want me to create in S5 for me to test and review for this issue.

The others come in at the node level. Not the model.
You may want to copy these two files into c:\program files\xlights and try again
 https://www.dropbox.com/sh/lu5p6pizjarvjas/AACZpCFWm7whvMQSO4gtyiTpa?dl=0


Sent from my iPhone using Tapatalk

[keithsw1111]

If folks want to give me examples here is what I need to reproduce what you see.

Your xlights_rgbeffects.xml and xlights_networks.xml files.
Your loredit file
Your xmap file ideally with just the models mapped that I need to look at.
Ideally a video of what it should look like.