Sean Meighan
Software => Bugs in xLights/Nutcracker => Topic started by: nmiller0113 on October 19, 2017, 01:04:56 AM
-
Setup - xLights BETA 2017.33 64 Mac (I also tested on the same 64bit version in Windows and had the same result)
I recorded this to better understand the issue. Here is the video link:
https://drive.google.com/open?id=0B7E6agkvZj6wWW9Vd1p1alhpSUk (https://drive.google.com/open?id=0B7E6agkvZj6wWW9Vd1p1alhpSUk)
I'll walk you through the video:
1 - I show you that I've created the model group "Whole House No LM,GA,HF1" and what is inside of it
2 - I then add the model group "Whole House No LM,GA,HF1" to the model group "Whole House" which appears to work until you click away and then back to find it added another model group in its place "Whole House No LM" which is obviously not what I selected
3 - I show step 2 once more to prove I'm not crazy and clicked the wrong thing :)
4 - Since it was adding / changing what I selected from "Whole House No LM,GA,HF1" to "Whole House No LM" I thought I'd try to add "Whole House No LM,GA,HF1" to the model group that it was changing it to "Whole House No LM" to see what happens. As you can see, it immediately crashes xLights
So I believe I've found a bug. I'm in the middle of cleaning up some of my model groups and consolidating things for ease of management but this is a blocker, at least for that. Hopefully it's an easy fix. I've also attached the log file package. Thanks for the help!
-
Well, the bug is that a comma should not be allowed in a model name or model group name. That will definitely cause issues.
-
Thanks Dan. Easy enough fix from my end. Should I submit a bug / feature enhancement in git on this? Can you tell me what characters are *not* allowed to be used in the model names so i don't do this again with something like a dash, pound or something else? Thanks!
-
I know Dash and underbar are ok, but generally you need to not use an special characters in any kind of names in FPP
-
The things that will cause the biggest problems would be the comma and the semi-colon as those are used as list separators in various places. The others that would be problematic are &, <, >, and the single and double quotes as those could potentially mess up the XML if not handled properly. In general, avoid any of the special chars, although the underscore and dash should work fine.
And yes... please file a bug.
-
I know Dash and underbar are ok, but generally you need to not use an special characters in any kind of names in FPP
Thanks Jim...just for the sake of saving any confusion for others...this is for xLights not FPP :) but thank you!
-
To save confusion Jim statement applies to both xLights, FPP, and pretty much anything you do on a computer.
-
To save confusion Jim statement applies to both xLights, FPP, and pretty much anything you do on a computer.
Gil, you just enjoy trolling don't you? If you're not trolling on Facebook you're doing it here :) Sure, it probably applies to FPP in some places but we're specifically talking about model groups here...so let's not derail the intent of this thread. Secondly...comma's are used as value separators in many functions so your statement of "pretty much anything you do on a computer" is completely false.
-
I'm not trolling. Using special characters for any type of names on a computer is unwise. Why do you think most of us don't run into these problems? Quit acting butthurt all the time.
-
Dan, GitHub issue filed https://github.com/smeighan/xLights/issues/962 (https://github.com/smeighan/xLights/issues/962)
-
I'm not trolling. Using special characters for any type of names on a computer is unwise. Why do you think most of us don't run into these problems? Quit acting butthurt all the time.
You didn't say naming, you said "pretty much anything you do on a computer". I'll stop calling you out on your false statement, or as you say "acting butthurt all the time", when your statements are true and not vaguely false. I'm also not sure where the "all the time" portion of your statement is even coming from. You come across as rude / condescending / insulting in your response...I doubt you intend it, but that's how it comes across.
I appreciate all you do for the community and have contributed as much as I can to show that appreciation...I just don't think you know how your responses come across to others sometimes.
-
It’s also not unheard of for a program to escape special characters on your behalf. Not saying it’s the norm.
-
Are you kidding? You have no idea the skill it takes to create a short sentence that causes someone to go postal...lol.
-
You are definitely the master there :)
I want to state again...I appreciate all you do for the community. I've been in this hobby for 7+ years now and nothing has ever come close to xLights!
-
To save confusion Jim statement applies to both xLights, FPP, and pretty much anything you do on a computer.
Still don't see what was so bad about this simple statement. Jim made a typo. He meant to say xLights. You reacted as if this simple quote was "rude, condescending, and insulting" and you accused me of making false statements. You have to admit that for this to set you off you are loaded for bear for anything I say.
-
To save confusion Jim statement applies to both xLights, FPP, and pretty much anything you do on a computer.
Still don't see what was so bad about this simple statement. Jim made a typo. He meant to say xLights. You reacted as if this simple quote was "rude, condescending, and insulting" and you accused me of making false statements. You have to admit that for this to set you off you are loaded for bear for anything I say.
My response around what I interpreted as rude or condescending was a mix of your two responses, but I was just messing around with the trolling statement to ya...as I know you like to mess with people. When you mentioned "pretty much anything you do on a computer" I didn't agree. I guess what really bothered me and eventually got me to say anything more is your second response saying "Why do you think most of us don't run into these problems? Quit acting butthurt all the time"....less the butthurt portion though that was kind of insulting, but more the "Why do you think most of us don't run into these problems". It is pretty much saying you're the outlier, you're the only one who doesn't get this...which is 100% not true. Yes, I know you *didn't* say that, but a lot is implied there...even if you may not agree or see it that way.
So if I assumed something in reading too much into your response, I'm sorry.
-
Over analyze much? LOL... dude I'm not even going to read something that long. Get over it.
-
Haha, ok :)
I’ll leave it with this. Whether you care to know this or not, I’m not the only one that’s taken exception to / over analyzed :) some of your comments and responses. In case that means anything to ya for the future.
Then again. No one here is paying you to do customer service...the software and infrastructure engineers I manage would have a field day with this one haha :)
-
Is this why we can't have random twinkles?
-
I hear Vixen3 allows commas...give it a try.
-
Or -- This can be corrected or isn't the problem in the first place...we'll soon know :)
https://github.com/smeighan/xLights/issues/962#issuecomment-338039885 (https://github.com/smeighan/xLights/issues/962#issuecomment-338039885)
-
Though i agree with Gil's statement...it's not a good practice to use those characters in a name.
-
I just got home and in 1 minute I confirmed my suspicions. We don't allow the comma in the current version. I just tried to rename a model group with a comma and we automatically remove it. So if you have commas in your names it happened a long time ago or through manual XML editing.
-
Thanks Gil. Yep, a long time ago. I've had them for the last 2 years.
-
So to fix an old file like that the model groups need to be fixed manually in an editor. I attached a copy that will work. But if you have any sequences that mapped effects to those groups you will be prompted when you open the sequence and will need to point them to the new names. Shouldn't take that long to fix them. Only one of those groups seemed to have any models in it.
-
got it...Thanks again Gil!
-
Sorry Gil, one last question...just out of curiosity. Why couldn't I just rename all the groups in xLights? You mentioned having to use an editor, so I just wanted to make sure I understood why that was a better way for future reference. Thanks!
-
So, I went ahead and actually recreated all my model groups with new names and repopulated them. I'm doing general cleanup right now. I fully understand I'll need to re-map when I load my previous sequences.
I've attached my xlights_rgbeffects.xml file. If you look at the allhsenolmgahf1 model it has the model group allflakes in it which also contains model groups allgrflakes and allrfflakes. What I've found is xLights doesn't seem to like double embedding of Model Groups as allflakes does not highlight in the layout though you can clearly see it's added in the XML file.
So maybe I'm just pressing my luck by placing a model group, within a model group and finally...within a model group, but as I said, I'm trying to cleanup my layout and make it a bit more organized so the fewer elements I need to add to each group the cleaner...but maybe I'm hitting a limit :)
Thanks again!
-
Sorry Gil, one last question...just out of curiosity. Why couldn't I just rename all the groups in xLights? You mentioned having to use an editor, so I just wanted to make sure I understood why that was a better way for future reference. Thanks!
I just wasn't sure it wouldn't crash upon opening xLights. If it doesn't crash and lets you change the names then that would work. There have been a few things like this where we've prevented the issue from happening in the future but we didn't install code to detect and cleanup and old instances mainly because the problem would exist in multiple files.
-
Ahhh. I understand. Better safe than add more issues. Did you see my last message in this thread regarding the model group, inside a model group, inside a model group result? Sorry to keep throwing things I find out there.
-
Yes there are a few issues once the groups get nested past the first level. It doesn't space the names on the grid correctly either but I think you can still sequence them. Dan got that feature going for us and told us it wasn't fully problem free.
-
Ahhh, ok. I won't do too much nesting then. Thanks!