Think I found a Model Group in Model Group bug

[nmiller0113]

Setup - xLights BETA 2017.33 64 Mac (I also tested on the same 64bit version in Windows and had the same result)

I recorded this to better understand the issue.  Here is the video link:
https://drive.google.com/open?id=0B7E6agkvZj6wWW9Vd1p1alhpSUk

I'll walk you through the video:
1 - I show you that I've created the model group "Whole House No LM,GA,HF1" and what is inside of it
2 - I then add the model group "Whole House No LM,GA,HF1" to the model group "Whole House" which appears to work until you click away and then back to find it added another model group in its place "Whole House No LM" which is obviously not what I selected
3 - I show step 2 once more to prove I'm not crazy and clicked the wrong thing
4 - Since it was adding / changing what I selected from "Whole House No LM,GA,HF1" to "Whole House No LM" I thought I'd try to add "Whole House No LM,GA,HF1" to the model group that it was changing it to "Whole House No LM" to see what happens.  As you can see, it immediately crashes xLights

So I believe I've found a bug.  I'm in the middle of cleaning up some of my model groups and consolidating things for ease of management but this is a blocker, at least for that.  Hopefully it's an easy fix.  I've also attached the log file package.  Thanks for the help!

[dkulp]

Well, the bug is that a comma should not be allowed in a model name or model group name.   That will definitely cause issues.

[nmiller0113]

Thanks Dan.  Easy enough fix from my end.  Should I submit a bug / feature enhancement in git on this?  Can you tell me what characters are *not* allowed to be used in the model names so i don't do this again with something like a dash, pound or something else?  Thanks!

[jnealand]

I know Dash and underbar are ok, but generally you need to not use an special characters in any kind of names in FPP

[dkulp]

The things that will cause the biggest problems would be the comma and the semi-colon as those are used as list separators in various places.   The others that would be problematic are  &, <,  >, and the single and double quotes as those could potentially mess up the XML if not handled properly.  In general, avoid any of the special chars, although the underscore and dash should work fine.

And yes... please file a bug.

[nmiller0113]

I know Dash and underbar are ok, but generally you need to not use an special characters in any kind of names in FPP

Thanks Jim...just for the sake of saving any confusion for others...this is for xLights not FPP but thank you!

[Gilrock]

To save confusion Jim statement applies to both xLights, FPP, and pretty much anything you do on a computer.

[nmiller0113]

To save confusion Jim statement applies to both xLights, FPP, and pretty much anything you do on a computer.

Gil, you just enjoy trolling don't you?  If you're not trolling on Facebook you're doing it here Sure, it probably applies to FPP in some places but we're specifically talking about model groups here...so let's not derail the intent of this thread.  Secondly...comma's are used as value separators in many functions so your statement of "pretty much anything you do on a computer" is completely false.

[Gilrock]

I'm not trolling.  Using special characters for any type of names on a computer is unwise.  Why do you think most of us don't run into these problems?  Quit acting butthurt all the time.

[nmiller0113]

Dan, GitHub issue filed https://github.com/smeighan/xLights/issues/962

[nmiller0113]

I'm not trolling.  Using special characters for any type of names on a computer is unwise.  Why do you think most of us don't run into these problems?  Quit acting butthurt all the time.

You didn't say naming, you said "pretty much anything you do on a computer".  I'll stop calling you out on your false statement, or as you say "acting butthurt all the time", when your statements are true and not vaguely false.  I'm also not sure where the "all the time" portion of your statement is even coming from.  You come across as rude / condescending / insulting in your response...I doubt you intend it, but that's how it comes across.

I appreciate all you do for the community and have contributed as much as I can to show that appreciation...I just don't think you know how your responses come across to others sometimes.

[nmiller0113]

It’s also not unheard of for a program to escape special characters on your behalf.  Not saying it’s the norm.

[Gilrock]

Are you kidding?  You have no idea the skill it takes to create a short sentence that causes someone to go postal...lol.

[nmiller0113]

You are definitely the master there

I want to state again...I appreciate all you do for the community.  I've been in this hobby for 7+ years now and nothing has ever come close to xLights!

[Gilrock]

To save confusion Jim statement applies to both xLights, FPP, and pretty much anything you do on a computer.

Still don't see what was so bad about this simple statement.  Jim made a typo.  He meant to say xLights.  You reacted as if this simple quote was "rude, condescending, and insulting" and you accused me of making false statements.  You have to admit that for this to set you off you are loaded for bear for anything I say.