Author Topic: Timing marks problem  (Read 7053 times)

Offline BobinWV

  • Jr. Member
  • **
  • Posts: 97
    • View Profile
Timing marks problem
« on: April 15, 2015, 10:36:42 AM »
Having problems with timing marks. NC4.0.20
Open New Sequence..select song..timing track is created....add some models and when I play the song timing is entered but the connecting links between the timing marks  is hit or miss.
I went back to NC4.0.17 and timing marking works perfectly.

BobinWV

Offline Gilrock

  • Supporting Member
  • Hero Member
  • *
  • Posts: 6946
    • View Profile
Re: Timing marks problem
« Reply #1 on: April 15, 2015, 11:30:45 AM »
It's not clear to me how you are creating the timing marks.

Offline sean

  • Administrator
  • Hero Member
  • *****
  • Posts: 1727
    • View Profile
    • Xlights and Nutcracker Forum
Re: Timing marks problem
« Reply #2 on: April 15, 2015, 11:37:21 AM »
i made a video showing the issue

https://vimeo.com/125066573
Sean
Littleton, CO
Latest releases http://nutcracker123.com/nutcracker/releases
xLights/Nutcracker Forum http://nutcracker123.com/forum/index.php
Fbook [url=https://www.facebook.com/groups/62

Offline flyinverted

  • Administrator
  • Hero Member
  • *****
  • Posts: 756
    • View Profile
Re: Timing marks problem
« Reply #3 on: April 15, 2015, 11:57:05 AM »
I had the double timing mark issue on one computer but not another.  A work around is to lower the keyboard repeat rate in Windows control panel. The double timing marks when pressing "t" while playing issue went away.

-Steve



Steve Giron
Maricopa County, AZ
xLights user with a boat-load of channels.

Do not ask to know all the answers, but ask to understand the question.

Offline jnealand

  • Hero Member
  • *****
  • Posts: 1421
    • View Profile
Re: Timing marks problem
« Reply #4 on: April 15, 2015, 02:10:45 PM »
i made a video showing the issue

https://vimeo.com/125066573

I have had all those issues occur.  Just another vote for the problem.
Jim Nealand
Kennesaw, GA

Offline Gilrock

  • Supporting Member
  • Hero Member
  • *
  • Posts: 6946
    • View Profile
Re: Timing marks problem
« Reply #5 on: April 15, 2015, 02:21:45 PM »
I'm at work I can't watch videos.  The original description didn't say how you were creating the timings.  It said "when I play the song timing is entered".  Does that mean you hit 't' while the sequence was playing?  Does it work ok when the sequence isn't playing?

Offline BobinWV

  • Jr. Member
  • **
  • Posts: 97
    • View Profile
Re: Timing marks problem
« Reply #6 on: April 15, 2015, 04:25:16 PM »
Sorry  for the confusion..yes I was using T to mark the timings.

Offline Gilrock

  • Supporting Member
  • Hero Member
  • *
  • Posts: 6946
    • View Profile
Re: Timing marks problem
« Reply #7 on: April 15, 2015, 06:05:10 PM »
Well this will be hard for me to fix because it's working perfect on my machine.

Offline Phrog30

  • Hero Member
  • *****
  • Posts: 1234
    • View Profile
Re: Timing marks problem
« Reply #8 on: April 15, 2015, 06:08:21 PM »
Would remoting (teamviewer etc) in to his machine help any? Just trying to help, sorry if this is silly idea.

Offline Gilrock

  • Supporting Member
  • Hero Member
  • *
  • Posts: 6946
    • View Profile
Re: Timing marks problem
« Reply #9 on: April 15, 2015, 06:38:01 PM »
It's happening to Sean also.  The best I can do right now is I'll try to inspect how we make the decision whether to connect to the previous timing mark because that's what isn't happening.

Offline Gilrock

  • Supporting Member
  • Hero Member
  • *
  • Posts: 6946
    • View Profile
Re: Timing marks problem
« Reply #10 on: April 15, 2015, 06:39:43 PM »
And I'm pretty sure what change I did that caused this.  The problem is the change I checked in was fixing another bug that nobody had reported.  Without that change you could keep hitting 't' and get a whole stack of timings in the same spot.

Offline Gilrock

  • Supporting Member
  • Hero Member
  • *
  • Posts: 6946
    • View Profile
Re: Timing marks problem
« Reply #11 on: April 15, 2015, 06:56:04 PM »
Ah I finally figured out how to recreate it.  I installed the release version.  Another case where it works great in the debug build but not in the release build.  This is caused by something I had worried about but convinced myself it was ok.  I'm doing a comparison of two floating point values which is normally a no no due to this exact reason.  For some reason the comparison is failing even though the exact same X position is being fed through the calculations.  So the comparison fails due to a floating point precision difference.  Not sure why this only occurs in release versions.  Probably something to do with the extra optimizations that occur for a release build.

Offline Phrog30

  • Hero Member
  • *****
  • Posts: 1234
    • View Profile
Re: Timing marks problem
« Reply #12 on: April 15, 2015, 07:16:21 PM »
As always, thanks for the time you spend on this.

Offline Gilrock

  • Supporting Member
  • Hero Member
  • *
  • Posts: 6946
    • View Profile
Re: Timing marks problem
« Reply #13 on: April 15, 2015, 07:27:48 PM »
Ok fix is checked in...balls in Sean's court. ;)