Crash on clicking "Remove Group"

[kevinp]

Just playing around with model groups and I noticed that xlights crashes every time that I highlight a group and then click the remove group button.  Version 4.0.24, running under Windows XP.  I'll have to try this once I'm home and can test on OS X.

[tomwb301]

The same thing is happening on my 8.1 machine. I figured it will all sort out with the final release.

[BobinWV]

Ditto

[sean]

Open an issue to track it on github. Sounds like a bug


Sent from my iPhone using Tapatalk

[Gilrock]

Please include as much info as possible like is the model you are deleting the only one in the list because I did see that crash.  Is it a wholehouse model?  Does the model you are deleting exist on the grid?  I know I tested deleting models because I had to make a change to that code back when it became a sorted list and things broke.

[Gilrock]

I just checked in a fix that I think will correct this.  It looked like the only way it would crash is if you were deleting the last model in the list because I was using the selection index to set the new one and if it was at the end then after deletion that index was out of bounds.

[kevinp]

I just opened a github issue (#217) while you were doing this too.  I couldn't duplicate the issue at home under OS X, but I did get a different error that I copied and pasted the dialog box information.  Hopefully that will help Dan fix the Mac side error?

[kevinp]

Correction, I can duplicate it under OS X.  And you're correct, it has to be the last item in the list of model groups.