Author Topic: Missing the hand indicatior when separating time marks  (Read 7215 times)

Offline RoboMello

  • Full Member
  • ***
  • Posts: 105
    • View Profile
Missing the hand indicatior when separating time marks
« on: September 08, 2015, 06:39:38 PM »
The title explain the problem.
Since 4.2.7 when you Zoom In past a certain point you no longer will have the option to separate time marks with the hand indication.
Sorry for the poor information, but if you used before, you will know what I am talking about.
If needed I can provide a video :-)

Thanks

RoboMello

Offline flyinverted

  • Administrator
  • Hero Member
  • *****
  • Posts: 756
    • View Profile
Re: Missing the hand indicatior when separating time marks
« Reply #1 on: September 08, 2015, 08:03:37 PM »
It's there but the selection zone is only a few pixels wide.
You need to zoom out a bit to get the hand to un-magnetize the effect from the adjacent effect.
Steve Giron
Maricopa County, AZ
xLights user with a boat-load of channels.

Do not ask to know all the answers, but ask to understand the question.

Offline RoboMello

  • Full Member
  • ***
  • Posts: 105
    • View Profile
Re: Missing the hand indicatior when separating time marks
« Reply #2 on: September 08, 2015, 08:11:27 PM »
It works on 2.4.6, and is gone on 2.4.7
And when you have time marks that are 1 second apart is hard to get the correct one and so on.

Offline Gilrock

  • Supporting Member
  • Hero Member
  • *
  • Posts: 6946
    • View Profile
Re: Missing the hand indicatior when separating time marks
« Reply #3 on: September 09, 2015, 09:28:07 AM »
The selection zones are a fixed number of pixels.  The edge cursor should be when it's 6 pixels from the edge and the hands should be the next 4 pixels.  I know Dan made a slight change to the selection of small effects.  It used to be that anything under 22 pixels and all you could do was a center selection and move the effect.  He changed it so that now anything under 8 pixels and it will only grab an edge to resize it.  I thought it seemed ok when I tested the changes.

I wouldn't mind seeing a video so I can see the size of your effects and which zoom level is having issues.

Offline RoboMello

  • Full Member
  • ***
  • Posts: 105
    • View Profile
Re: Missing the hand indicatior when separating time marks
« Reply #4 on: September 09, 2015, 05:31:59 PM »
Hopefully this Video helps

https://youtu.be/6cPBms9r3qA

Thank you

RoboMello

Offline Phrog30

  • Hero Member
  • *****
  • Posts: 1234
    • View Profile
Re: Missing the hand indicatior when separating time marks
« Reply #5 on: September 09, 2015, 05:38:48 PM »
I did some sequencing today and some effects would have the hand, but didn't have the ability to grab from each end, matter of fact I could usually grab the left side but not the right. So, it was always reversed, if I could grab the right side, the hand wouldn't work. If the hand would work, I couldn't grab the side.

Offline Gilrock

  • Supporting Member
  • Hero Member
  • *
  • Posts: 6946
    • View Profile
Re: Missing the hand indicatior when separating time marks
« Reply #6 on: September 09, 2015, 10:17:22 PM »
Ok I checked in a fix.  The changes that were done in 4.2.7 were converting the mouse position to time and then back to a position for hit testing but the conversion to time was calling the function that rounds the time to the nearest frequency interval.  So basically if you had a 50ms sequence you were only getting mouse positions rounded to the 50ms intervals so several pixel positions were not achievable causing it to skip over the positions that gave you the hand.  This did actually get worse the more you zoom in so I'm sure when I tested Dan's original changes I wasn't zooming in enough to see this problem.

Offline sean

  • Administrator
  • Hero Member
  • *****
  • Posts: 1727
    • View Profile
    • Xlights and Nutcracker Forum
Re: Missing the hand indicatior when separating time marks
« Reply #7 on: September 10, 2015, 02:28:44 AM »
released 4.2.9 with this fix
Sean
Littleton, CO
Latest releases http://nutcracker123.com/nutcracker/releases
xLights/Nutcracker Forum http://nutcracker123.com/forum/index.php
Fbook [url=https://www.facebook.com/groups/62

Offline RoboMello

  • Full Member
  • ***
  • Posts: 105
    • View Profile
Re: Missing the hand indicatior when separating time marks
« Reply #8 on: September 10, 2015, 02:56:10 AM »
Ok I checked in a fix.  The changes that were done in 4.2.7 were converting the mouse position to time and then back to a position for hit testing but the conversion to time was calling the function that rounds the time to the nearest frequency interval.  So basically if you had a 50ms sequence you were only getting mouse positions rounded to the 50ms intervals so several pixel positions were not achievable causing it to skip over the positions that gave you the hand.  This did actually get worse the more you zoom in so I'm sure when I tested Dan's original changes I wasn't zooming in enough to see this problem.

I got lost on the 1st conversion to conversion :-)
Thank you for fixing it, sorry for being annoying.

RoboMello

Offline RoboMello

  • Full Member
  • ***
  • Posts: 105
    • View Profile
Re: Missing the hand indicatior when separating time marks
« Reply #9 on: September 10, 2015, 02:56:51 AM »
released 4.2.9 with this fix

Thank you, works fine now :-)

RoboMello

Offline Gilrock

  • Supporting Member
  • Hero Member
  • *
  • Posts: 6946
    • View Profile
Re: Missing the hand indicatior when separating time marks
« Reply #10 on: September 10, 2015, 07:27:26 AM »
Ok I checked in a fix.  The changes that were done in 4.2.7 were converting the mouse position to time and then back to a position for hit testing but the conversion to time was calling the function that rounds the time to the nearest frequency interval.  So basically if you had a 50ms sequence you were only getting mouse positions rounded to the 50ms intervals so several pixel positions were not achievable causing it to skip over the positions that gave you the hand.  This did actually get worse the more you zoom in so I'm sure when I tested Dan's original changes I wasn't zooming in enough to see this problem.

I got lost on the 1st conversion to conversion :-)
Thank you for fixing it, sorry for being annoying.

RoboMello

Yeah sometimes I go into too much detail.  Basically if you zoom way in and drag and effect edge you will see how it snaps to the 50ms lines.  Well just imagine the mouse position was doing the same thing internally so it never could respond to any of the inbetween positions.  That's why the further you zoomed in the worse it got because you were expanding the dead zones.

Offline rando1957

  • Full Member
  • ***
  • Posts: 200
    • View Profile
Re: Missing the hand indicatior when separating time marks
« Reply #11 on: September 10, 2015, 07:41:01 AM »
Just curious if anyone is having issues with the copy/paste functionality using the 50ms timings?  I updated to 4.2.9 and that definitely helped the selection and highlighting cells, but I am unable to highlight a fade up and down effect across multiple cells and do a copy/paste.  I can select one effect and copy/paste find but joining fade up and down effects, I can not do that. I was doing this fine on 4.2.5 until i started had a lot of XL crashes which I posted yesterday.  I appreciate this selection fix and can work on my sequences; just not as fast.
Randy McMasters
Graham, NC

Offline Gilrock

  • Supporting Member
  • Hero Member
  • *
  • Posts: 6946
    • View Profile
Re: Missing the hand indicatior when separating time marks
« Reply #12 on: September 10, 2015, 08:02:16 AM »
The copy/paste logic doesn't care what type of effect it's copying.  Are you talking about the ON effect with ramp intensities?  I really don't know what a fade up and down effect is because you could be talking about using the fade text boxes on any effect.  Why don't you just click on one of the effects, copy it, and paste it into this thread?

Offline rando1957

  • Full Member
  • ***
  • Posts: 200
    • View Profile
Re: Missing the hand indicatior when separating time marks
« Reply #13 on: September 10, 2015, 08:30:52 AM »
Yes Gil - what I call fade up and down is the ON effect where it goes from 0 intensity to 100 (or some value) and fade down is the ON effect where intensity starts at 100 (or some value and goes down to lower value.  I have a increasing ramp and decreasing ramps back to back so I select both and try to copy / paste. Does not work for me. I can select one and copy/paste fine.  Used to select a range of effects and copy /paste but that is not working for me.  Note: this is at the 50ms timing setting using windows.
Randy McMasters
Graham, NC

Offline Gilrock

  • Supporting Member
  • Hero Member
  • *
  • Posts: 6946
    • View Profile
Re: Missing the hand indicatior when separating time marks
« Reply #14 on: September 10, 2015, 09:16:47 AM »
Well I'm not able to look at this for several hours so the more investigating you can do the better.  Try it with two other effects because I suspect it has nothing to do with the effect type.  Try pasting in a completely open area with nothing interfering on both sides of where you are pasting.  It sounds like its only a problem when you are copying multiple effects.  Does it paste any of them?  It's possible the updated logic using time instead of position is incorrectly thinking that adjoining effects are blocking each other since the end marker and start marker of the next effect share the same spot.  Try pasting a single effect and then pasting again in a cell directly beside it.  You should be able to determine a pattern of exactly what isn't working.