Put Nutcracker mod into production?

[johnty]

Sean,

I've been using the Glediator 'Capture' function to bring videos into Nutcracker.  It works very well and the videos look good in the Glediator and Nutcracker pixel windows but when I send the data to my lights (TM1804ICs from Ray), the result is very pastel, a washed out look with many pixels bordering on white instead of the color displayed on my monitor.

I decided a tweak to the pixel's color saturation was needed so I modified the Glediator effects panel in Nutcracker and changed the code from an RGB to a HSV model, then I added sliders for Hue, Saturation and Value.  Works great.  Makes a HUGH difference in the pixel display.  Videos that looked pretty sad are now most useable for this years Christmas display.

It would be great if you could incorporate the changes in the production version of xLights so that I don't have to make my changes to each new release.  I also think anyone capturing video will find the mod very useful.  Can you send me a PM telling me where to send the files and docs?

John Tyson

[dkulp]

Best option is to just fork the repo on github and issue a pull request.

[johnty]

Best option is to just fork the repo on github and issue a pull request.

Thanks dkulp.  I've forked, pulled, pushed, inited, committed, etc. according to the docs and tutorials I've studied for GitHub.  I'm not having much luck.  Although my fork (johnty4321/xLights) does show up on GitHub it doesn't appear on a xLights search listing where yours shows up. 

Is the basic concept here that the changes to my forked code are somehow merged back into the production copy at some point?  Any pointers on how to make this happen from my local Windows GitHub and its associated xLights directory?

[dkulp]

The fork looks fine.   You haven't pushed any of your own changes there yet though. At least not to the master branch. 

Once your changes are pushed there so that there is something different there compared to Sean's repo, there should then be a submit pull request button that you can click on which should guide you through.

[keithsw1112]

Is there somewhere I can find instructions on the right way to publish code changes such that they can be considered for inclusion in an upcoming release of XLights. I cloned smeighan's github project and made the code changes, compiled and tested it but when I try to push my changes back I get 403 errors. I suspect because I should have forked first ... but being a bit of a noob to github I am not sure what I should have done to do this right. I have now forked the project but I am not sure if that is the right thing to do and I have not pushed my changes there yet.

[Gilrock]

I'm really not sure because those of us doing the main work can checkin our code directly the branch that is used for releases.  Reading this thread it sounds like it gives all the advice you need.  Create a fork, submit your changes there and do a Pull request.  But you should probably be communicating your ideas with us first.  There is a lot of change going on daily and you might be stepping on some of the same files we have in progress work occurring on.