VERY Long Render Times / Corrupt RGBEFFECTS file after exit - Related?

[robskimeister]

Hi!

I've recently been testing the new versions of Xlights & love all the new stuff!  Keep up the good work!

Unfortunately I've also hit a few snags.  It could be something I've done wrong in my setup (I'm a noob and still learning!), but I thought I'd post in case it's a glitch or a bug that needs to be squashed.

For my 2015 show I used version 4.2.17 & it worked great!  Recently I tried out 2016.9 & immediately noticed that the render times were MUCH longer compared to XL4.  In 2016.11 it's still the same.  Here are the comparisons of the render times (in seconds) for some of my sequences:

--------------------------------------------------------------------
Using top-of-the-line Core i7 laptop (HP Zbook)      
      
                          Version 4.2.17   Version 2016.11
Joy to the World              30             191
Let it Go                          40               96
Christmas Eve Sarajevo   18               77
Sammy                           13               38
Wizards in Winter            15               72
Star Wars                       38               17*
-Renard Test Sequence-   6            1626**
      
   *  This one renders faster in new version - why are other sequences SLOWER?   
   ** Why the HUGE difference in this one?
--------------------------------------------------------------------
I noticed that it seemed to "hang" when processing a large group of models, notably these 2:  "House-All Models" and "Everything!"

After rendering the last sequence above (the one that took 1626 seconds), I exited xLights & was asked to save everything, so I did.  FYI:  I made no changes to anything.  I opened xLights, rendered some sequences & exited.

When I opened xLights back up, I got an error box that said "Unable to load RGB effects file"
Then another box said, "XML parsing error: 'duplicate attribute' at line 595"

This is the code on line 595 from my RGBeffects file:

Code: [Select]

<perspective name="Default" settings="layout2|name=ModelPreview;caption=Model Preview;state=2099196;dir=3;layer=1;row=0;pos=0;prop=100000;bestw=200;besth=200;minw=-1;minh=-1;maxw=-1;maxh=-1;floatx=423;floaty=923;floatw=216;floath=239|name=HousePreview;caption=House Preview;state=2099196;dir=3;layer=1;row=0;pos=1;prop=100000;bestw=200;besth=200;minw=-1;minh=-1;maxw=-1;maxh=-1;floatx=1026;floaty=790;floatw=1538;floath=1025|name=EffectAssist;caption=Effect Assist;state=2099198;dir=4;layer=0;row=0;pos=0;prop=100000;bestw=200;besth=200;minw=-1;minh=-1;maxw=-1;maxh=-1;floatx=-1;floaty=-1;floatw=-1;floath=-1|name=DisplayElements;caption=Display Elements;state=2099199;dir=4;layer=0;row=0;pos=0;prop=100000;bestw=357;besth=467;minw=-1;minh=-1;maxw=-1;maxh=-1;floatx=78;floaty=78;floatw=373;floath=506|name=Perspectives;caption=Perspectives;state=2115581;dir=4;layer=0;row=0;pos=0;prop=100000;bestw=233;besth=162;minw=-1;minh=-1;maxw=-1;maxh=-1;floatx=637;floaty=380;floatw=251;floath=209|name=EffectDropper;caption=Effects;state=2099198;dir=4;layer=0;row=0;pos=2;prop=100000;bestw=150;besth=182;minw=150;minh=150;maxw=-1;maxh=-1;floatx=-1;floaty=-1;floatw=-1;floath=-1|name=Effect;caption=Effect Settings;state=2099196;dir=4;layer=0;row=0;pos=0;prop=151465;bestw=175;besth=175;minw=175;minh=175;maxw=-1;maxh=-1;floatx=-1;floaty=-1;floatw=-1;floath=-1|name=Color;caption=Color;state=2099196;dir=4;layer=0;row=0;pos=1;prop=72801;bestw=237;besth=164;minw=-1;minh=-1;maxw=-1;maxh=-1;floatx=-1;floaty=-1;floatw=-1;floath=-1|name=LayerTiming;caption=Layer Blending;state=2099196;dir=4;layer=0;row=0;pos=2;prop=75734;bestw=778;besth=707;minw=-1;minh=-1;maxw=-1;maxh=-1;floatx=-1;floaty=-1;floatw=-1;floath=-1|name=Main Sequencer;caption=Main Sequencer;state=768;dir=5;layer=0;row=0;pos=0;prop=100000;bestw=297;besth=255;minw=-1;minh=-1;maxw=-1;maxh=-1;floatx=-1;floaty=-1;floatw=-1;floath=-1|dock_size(4,0,0)=422|dock_size(5,0,0)=299|dock_size(3,1,0)=212|" version="2.0" settings="layout2|name=ModelPreview;caption=Model Preview;state=2099196;dir=3;layer=1;row=0;pos=0;prop=100000;bestw=200;besth=200;minw=-1;minh=-1;maxw=-1;maxh=-1;floatx=423;floaty=923;floatw=216;floath=239|name=HousePreview;caption=House Preview;state=2099196;dir=3;layer=1;row=0;pos=1;prop=100000;bestw=200;besth=200;minw=-1;minh=-1;maxw=-1;maxh=-1;floatx=1026;floaty=790;floatw=1538;floath=1025|name=EffectAssist;caption=Effect Assist;state=2099198;dir=4;layer=0;row=0;pos=0;prop=100000;bestw=200;besth=200;minw=-1;minh=-1;maxw=-1;maxh=-1;floatx=-1;floaty=-1;floatw=-1;floath=-1|name=DisplayElements;caption=Display Elements;state=2099199;dir=4;layer=0;row=0;pos=0;prop=100000;bestw=357;besth=467;minw=-1;minh=-1;maxw=-1;maxh=-1;floatx=78;floaty=78;floatw=373;floath=506|name=Perspectives;caption=Perspectives;state=2115581;dir=4;layer=0;row=0;pos=0;prop=100000;bestw=233;besth=162;minw=-1;minh=-1;maxw=-1;maxh=-1;floatx=637;floaty=380;floatw=251;floath=209|name=Effect;caption=Effect Settings;state=2099196;dir=4;layer=0;row=0;pos=0;prop=151465;bestw=175;besth=175;minw=175;minh=175;maxw=-1;maxh=-1;floatx=-1;floaty=-1;floatw=-1;floath=-1|name=EffectDropper;caption=Effects;state=2099198;dir=4;layer=0;row=0;pos=2;prop=100000;bestw=150;besth=182;minw=150;minh=150;maxw=-1;maxh=-1;floatx=-1;floaty=-1;floatw=-1;floath=-1|name=Color;caption=Color;state=2099196;dir=4;layer=0;row=0;pos=1;prop=72801;bestw=237;besth=164;minw=-1;minh=-1;maxw=-1;maxh=-1;floatx=-1;floaty=-1;floatw=-1;floath=-1|name=LayerTiming;caption=Layer Blending;state=2099196;dir=4;layer=0;row=0;pos=2;prop=75734;bestw=778;besth=707;minw=-1;minh=-1;maxw=-1;maxh=-1;floatx=-1;floaty=-1;floatw=-1;floath=-1|name=LayerSettings;caption=Layer Settings;state=2099196;dir=4;layer=0;row=0;pos=3;prop=100000;bestw=284;besth=246;minw=-1;minh=-1;maxw=-1;maxh=-1;floatx=-1;floaty=-1;floatw=-1;floath=-1|name=Main Sequencer;caption=Main Sequencer;state=768;dir=5;layer=0;row=0;pos=0;prop=100000;bestw=297;besth=255;minw=-1;minh=-1;maxw=-1;maxh=-1;floatx=-1;floaty=-1;floatw=-1;floath=-1|dock_size(4,0,0)=422|dock_size(5,0,0)=299|dock_size(3,1,0)=212|"/>
I compared it to a backup version & found that some code had been appended to the end of this line of code.  If you search for "version", you'll jump to it.  This is how the newly-appended code begins:  version="2.0" settings="layout2|name=ModelPreview;caption=Model (...and it keeps going)

If I delete all the "new" code, the file loads again.

...but this occurred a 2nd time after rendering some sequences, saving & exiting.  So is this a glitch?  Is it related to the long rendering?

Please let me know if there's something in my setup that could be causing this, and if you need any additional information or files.  I've attached my "bad" RBGeffects file, keybindings file, and the test sequence that took 1626 seconds to render.   

Thanks in advance for any help/info!

[dkulp]

You have a couple of models that are off the left/bottom of the preview (so negative screen coordinates).  When setting up the buffer, we weren't adjusting properly for that case and the buffer ended up HUGE. 

[robskimeister]

You have a couple of models that are off the left/bottom of the preview (so negative screen coordinates).  When setting up the buffer, we weren't adjusting properly for that case and the buffer ended up HUGE. 

Hmmm... that's weird. 

Do you remember which models had the bad coordinates so I can fix them or delete them? 
...or is there a way I can find them; what do I search for?

Also, is this the cause of the corrupt file?

Thanks for the help!   

[Gilrock]

Dan checked in a change that will prevent an off screen model from causing this problem.

The corrupt file I believe was totally unrelated.  That looks like it has to do with the change in Perspectives.  The easiest fix is just delete the entire Perspectives section from the rgb_effects file.  Of course you will need to re-organize your windows.

[sean]

I deleted the perspective section, put your updated xlights_rgbeffect.xml into a new show directory.
I opened the sequence you gave. It does a save with latest code (2016.12) in 4.3 seconds as compared to your 6 seconds with the old code. My computer is an i7, so i am guessing maybe the same speed as you had before.

Since i didnt try to fix any models in your display, i am guessing Dan's fix does work.

Notice i changed the display resolution from your 1200x720  to 1000x600, everything fits better

attached  is screen shot of your layout.

thanks

[robskimeister]

Cool!  I appreciate you all taking the time to look at this.

So you think it's OK to leave those 2 models that are off the screen?  I'm concerned that it may possibly cause potential issues in the future if left in there (even though it works now)... and I'm sort-of OCD!

Thanks again for the quick response!   

[sean]

greg; can you send your xlights_rgbeffectrs.xml file to xlights@nutcracker123.com? If we can duplicate the issue, Dan or Gil can fix it. Probably the current xlights_rgbeffects.xml has been fixed by doing a save. Maybe send me the xlights_rgbeffects files from your backup directory. You are pressing F10 every-time you modify a file??

[Gilrock]

I think Dan already fixed the code so that off screen models won't cause the problem that happened here.  As for the question about whether to move them I think you have enough info to decide for yourself.  It won't cause the program an issue after you get this fix but why leave it that way where you can never see the model?

[sean]

yeah gil; i verified that the current code fixes his issue. Total save time was 4.3 seconds.

[Santacarl]

Guys...thought I'd add an observation.

I just converted an old file from last year (it wasn't a WHM).  I'm adding some elements this year though and when I went to save it with a new file name a 2 minute sequence took 395 seconds to render.....  Don't know if that's because I added an element to it or not....and since I did a "save as" I also don't know if that's a factor....

It did work though and didn't blow up my RGBEffects file....

UPDATE: I tried the same process on a second sequence but it was only 1 minute long.....this one took 13.6 seconds to render....so I'm guessing there was just something in that first one that caused the long render time.  I did change up the elements quite a bit before saving it.  I consolidated all the pixels on the house itself into 1 element where as it was broken down to windows and eves.....  All that tinkering might have thrown a curve ball....

[Gilrock]

Santa...certain effects can increase the render/save time quite a bit.

[Santacarl]

Santa...certain effects can increase the render/save time quite a bit.

Ahhh, IC....  Thanks Gil.....that makes sense.  It wasn't a problem or complaint on my part....just thought I'd contribute a little user 'data' on the fix.