Crash in sequencing tab when click on group item-repeatable

[robskimeister]

Hi! 

I'm getting a couple of different (but similar) crashes when I perform the following steps in 2016.15:

Open Xlights
Click sequencer tab
File --> Open Sequence --> Testing.xml (FYI: It crashes in all my other sequences too; not just this one)
Click the dropdown under View:  --> Select Rob
Left click any of the group items in the model list and it crashes every time


It also crashes when I do this:
Open Xlights
Click sequencer tab
File --> Open Sequence --> Testing.xml
Click the dropdown under View:  --> Select Rob
Right click on the model list to bring up the menu
Select Edit Display Elements (The Display Elements window pops up)
Click Rob in the top window
Click Add on the right side

NOTE:  These crashes also happened in earlier versions (2016.12 thru 2016.15 I think).  I was hoping the recent upgrades might fix these issues, but they still occur in 2016.15.

I've attached the ZIP files for these 2 crashes.  Please let me know if any other information is needed.

BTW I love the new features in 2016.15 and enjoyed the webinar last night!  You guys rock!   

[robskimeister]

I also noticed a small issue with the icons at the top of the screen.  There are 5 "groups" of icons that are in separate boxes.  In each of those boxes, the rightmost icon is being truncated and isn't visible.

I noticed this when my "Render All" icon was missing!   

Sean also ran into this during the webinar last night when the "Output to lights" icon was missing.  Someone suggested to undock the box and re-dock it to make it reappear, and it did.

So if anyone runs into this, the quick fix is to simply move each icon group box around a bit & put it back.  I had to do this for all 5 boxes.

[Gilrock]

That icon issue happens anytime we add a new icon to an existing toolbar.  The reset toolbars option should fix it but I've always used the undock/dock method to fix it.  The size of the toolbars must get saved with the perspectives and it doesn't know we've made one bigger.  I'm not sure how this could be corrected.  We could automatically reset your toolbars if that would even fix it.  Not sure people want that because it may move them back to default locations.  Plus I always hate having one time fix code in the program that you are stuck running way after it's needed.

[dkulp]

Actually, I think it's a wxWidgets 3.1 thing in this case.  I think 3.1 is adding an additional pixel to the borders which is making the toolbar buttons a bit bigger than they used to be so they no longer fit in the area where we have saved in the perspective.

[Gilrock]

Yeah if it happened to existing toolbars then that's probably the case.  But I know the same thing used to happen to me any time we added a new button.

[dkulp]

Just pushed a fix that fixes the crash.

The "Rob" view has a few models (DW Arches-Left, DW Arches-Right, couple others) that don't exist so it's getting a null pointer.  If you edit the XML, you can likely clean that up.

[Gilrock]

So one thing that would be good to know is what version of xLights were you running when you deleted those models.  We have code in place that is supposed to remove them from the Views so either you caused this issue with an old version of xLights before we had the fix to remove deleted models from views or we have a problem in our current code that is not removing them correctly.

[robskimeister]

So one thing that would be good to know is what version of xLights were you running when you deleted those models.

I'm not sure which exact version I was using, but it was definitely 2016.9 or later.

I'm sure of that because I was still running 4.2.17 from last November when I upgraded to 2016.9.  I think I skipped 2016.10 & jumped to 2016.11.  Then I've kept current versions ever since. 

Hope that helps!

[robskimeister]

Just pushed a fix that fixes the crash.

The "Rob" view has a few models (DW Arches-Left, DW Arches-Right, couple others) that don't exist so it's getting a null pointer.  If you edit the XML, you can likely clean that up.

I should've known it was something funky that I did to crash the program!   Last time I had models off the screen! 

I'll see if I can figure out how to clean up the XML without crashing something else.   

Thanks for the quick fix! 

[Gilrock]

So one thing that would be good to know is what version of xLights were you running when you deleted those models.

I'm not sure which exact version I was using, but it was definitely 2016.9 or later.

I'm sure of that because I was still running 4.2.17 from last November when I upgraded to 2016.9.  I think I skipped 2016.10 & jumped to 2016.11.  Then I've kept current versions ever since. 

Hope that helps!

Did you ever do any manual editing of the rgbeffect xml file?

[sean]

I will be doing a release sometime today that has at least two fixes for crashes. I am waiting to see if Dan or Gil have any more content. So since this will be fixed by end of day I would probably not edit the xlights_rgbeffects.xml.

[robskimeister]

Did you ever do any manual editing of the rgbeffect xml file?

I've dabbled a little, but nothing major.   I usually only just look around in the XML. 

The only thing I remember actually changing was to correct that perspective bug a few versions ago.  I deleted the entire perspective entry to fix.  I don't think I've changed anything related to models at all... nothing that would result in these non-existent models.  I do mostly all my changes through the UI.

I do remember renaming some things, and when I opened up a sequence I was prompted to delete or rename the model that I had changed.  I renamed it in my scenario. 

Also... the 2 models that dkulp mentioned (DW Arches-Left, DW Arches-Right) were groups, not standalone models.  I'm not sure if that's significant or not.   

In addition, I just checked and the 2 groups mentioned above & they were renamed.  The new names are:  Arches-DW-LEFT and Arches-DW-Right.

Does that help?

[robskimeister]

I do remember renaming some things

I should've been more clear that I did the renaming through the UI, not in the XML.

[Gilrock]

Yep that helps.  I'm betting the code where all those dialogs pop up to rename the models doesn't handle renaming them in the views but I'll have to check.

[robskimeister]

I found another "oddity" that may be a bug.  I can start a new thread if needed, but I figure I'd mention it here first since you have my files & stuff here in my first post.

In the Layout for my display I have several strings of strobes that are now only displaying one node.  The model names all have the prefix "Strobes-" if you need to locate them to verify. 

Also it's VERY difficult to select anything in the layout.  When I try to click a model in the layout, 9 out of 10 times I "miss" and a red line pops up somewhere in the layout for a seemingly random model that's nowhere near the area where I clicked.

BTW, I hope it doesn't seem like I'm complaining.  I understand that this is beta software.  I consider myself sort-of like a beta tester and I'm just reporting some of my findings to help make this awesome piece of software even better!

Thanks again for all the help & hard work!