Author Topic: Lilia Sequence: Hallelujah (Full Model Version) by Pentatonix  (Read 6818 times)

Offline sean

  • Administrator
  • Hero Member
  • *****
  • Posts: 1727
    • View Profile
    • Xlights and Nutcracker Forum
Lilia Sequence: Hallelujah (Full Model Version) by Pentatonix
« on: December 06, 2016, 08:58:01 PM »
New sequence from Lilia: Hallelujah by Pentatonix (Full House version).

$50 from Lilia store http://www.nutcracker123.com/store/product_info.php?cPath=3&products_id=84&osCsid=2tht2411bqa2js2h1hsofaj326

Lilia took her Megatree/Star version and mapped it onto all of the models on out house. She has also changed some settings on the megatree to make it look better on our 16x50 megatree. The original Hallelujah was created for a 54x100 tree.

If you have already purchased the $40 version of Hallelujah, make a $10 payment to paypal account nutcracker123.com. After you have done this, send me an email at xlights@nutcracker123.com and I will send you the full version.
Sean
Littleton, CO
Latest releases http://nutcracker123.com/nutcracker/releases
xLights/Nutcracker Forum http://nutcracker123.com/forum/index.php
Fbook [url=https://www.facebook.com/groups/62

Offline pixelpuppy

  • Jr. Member
  • **
  • Posts: 73
    • View Profile
Re: Lilia Sequence: Hallelujah (Full Model Version) by Pentatonix
« Reply #1 on: January 03, 2017, 01:10:08 PM »
This is an awesome sequence and my wife just love Love LOVES it.  BUT....

As of xLights version 2016.55 and up, this sequence no longer renders as originally intended (clever use of pinwheel effect in many places).

Just curious if Lilia is planning to update this sequence to work with the current version of xLights and if so, will there be a mechanism for those of us who bought it to get an update?

Offline Gilrock

  • Supporting Member
  • Hero Member
  • *
  • Posts: 6946
    • View Profile
Re: Lilia Sequence: Hallelujah (Full Model Version) by Pentatonix
« Reply #2 on: January 03, 2017, 01:37:32 PM »
It was broke in 2016.55 and fixed in 2016.56 so if you disagree show some evidence.

Offline Phrog30

  • Hero Member
  • *****
  • Posts: 1234
    • View Profile
Re: Lilia Sequence: Hallelujah (Full Model Version) by Pentatonix
« Reply #3 on: January 03, 2017, 01:40:33 PM »
He did in this thread, http://nutcracker123.com/forum/index.php?topic=4014.0

Sent from my Pixel using Tapatalk


Offline Gilrock

  • Supporting Member
  • Hero Member
  • *
  • Posts: 6946
    • View Profile
Re: Lilia Sequence: Hallelujah (Full Model Version) by Pentatonix
« Reply #4 on: January 03, 2017, 01:42:59 PM »
I didn't see that post.  That's the problem with everyone trying to post problems in the same thread.  I wish Sean would just lock the release threads.  Anyways I was just going on the statement from Sean when he told Chris that Lilia's sequence was fixed by v56.

Offline Gilrock

  • Supporting Member
  • Hero Member
  • *
  • Posts: 6946
    • View Profile
Re: Lilia Sequence: Hallelujah (Full Model Version) by Pentatonix
« Reply #5 on: January 03, 2017, 01:45:22 PM »
I tried to verify that the first time it was mentioned.  The problem is you never told us where in the sequence that occurs.  I didn't find anywhere in the sequence where it just stood still like a cross it was always sweeping around and it never looked like the image you are showing so did you move it to a different sized model?  Maybe that's the issue.

Offline pixelpuppy

  • Jr. Member
  • **
  • Posts: 73
    • View Profile
Re: Lilia Sequence: Hallelujah (Full Model Version) by Pentatonix
« Reply #6 on: January 03, 2017, 02:13:37 PM »
The problem is you never told us where in the sequence that occurs.  I didn't find anywhere in the sequence where it just stood still like a cross it was always sweeping around and it never looked like the image you are showing so did you move it to a different sized model?  Maybe that's the issue.
Try looking at 3:29 - 4:02.  Its the dramatic crescendo of the song and its over 30 seconds long.

Offline Gilrock

  • Supporting Member
  • Hero Member
  • *
  • Posts: 6946
    • View Profile
Re: Lilia Sequence: Hallelujah (Full Model Version) by Pentatonix
« Reply #7 on: January 03, 2017, 02:15:36 PM »
Can you tell us what size tree model you are using?

Offline pixelpuppy

  • Jr. Member
  • **
  • Posts: 73
    • View Profile
Re: Lilia Sequence: Hallelujah (Full Model Version) by Pentatonix
« Reply #8 on: January 03, 2017, 02:24:57 PM »
I tried it on:

24x50 tree
16x25 tree
8x18 tree
48x128 matrix

renders fine on all these different size models with version .54   
renders wrong on all these models with version .55 and .56

edit: attached "evidence" from the other thread..

I tried this on .56 and its a little different than .55 but still pretty far off from .54 (see pics).   

Attached pics are:
Lilia "pinwheel cross" rendered with xLights 2016.56
Lilia "pinwheel cross" rendered with xLights 2016.55
Lilia "pinwheel cross" rendered with xLights 2016.54

« Last Edit: January 03, 2017, 02:35:45 PM by pixelpuppy »

Offline Gilrock

  • Supporting Member
  • Hero Member
  • *
  • Posts: 6946
    • View Profile
Re: Lilia Sequence: Hallelujah (Full Model Version) by Pentatonix
« Reply #9 on: January 03, 2017, 03:24:18 PM »
I tested on the 54x100 that it was created for.

Offline kentd

  • Full Member
  • ***
  • Posts: 201
    • View Profile
Re: Lilia Sequence: Hallelujah (Full Model Version) by Pentatonix
« Reply #10 on: January 03, 2017, 04:31:25 PM »
One thing I found was that 56 needed to have the fseq files deleted and then re rendered then there was not any problem, as my version I purchased is working just fine when I did this.
Kent Davis
Davis County UT

Offline pixelpuppy

  • Jr. Member
  • **
  • Posts: 73
    • View Profile
Re: Lilia Sequence: Hallelujah (Full Model Version) by Pentatonix
« Reply #11 on: January 03, 2017, 05:22:04 PM »
I tested on the 54x100 that it was created for.

Are you implying that it should only work on a 54x100 tree???   That's bunk as it would make purchasing this sequence pretty much worthless to most people.  And if that's true then I want a refund  >:(

Did you actually test it or just jump to conclusions like you did earlier?  Because I also tested on a 54x100 model and 16x50 model and it still looks wrong. (see attached pics of both 54x100 tree and 16x50 tree) Did you test it the same way you "didn't see it anywhere in the song" even though its pretty obvious if you actually looked instead of jumping to conclusions or assuming I'm stupid?   The main reason you don't see me with a lot of posts here is because I do research and lots of testing before posting any issues or frivolous questions.

#1 In the original post by Sean, he states that this Full House sequence was modified from the original 54x100 to look better on their 16x50 tree.  So why should I expect it to only work on a 54x100 tree?  Even then, it should look right on those two model sizes but it doesn't (see attached pics)

#2 If we are only supposed to expect these sequences to work on models that exactly match Sean's layout then what's the point of buying sequences?  I don't think anybody else has the exact same layout as Sean. 

#3 It worked beautifully with my models on version .54 even though my models don't exactly match Sean's.  No problems copying the effects to different models.  It didn't break by having different models, it broke by changing the code for pinwheel.

#4 With .55 and .56 even testing with Sean's layout (his xlights_rgbeffects.xml file is included with the purchased sequence) it doesn't render properly.   See attached pic of Sean's house with two tree's and matrix all snapped at about the 3:30 mark where they should all be showing a non-rotating cross.  Only the matrix is somewhat similar to the original intended effect.

I think I've provided more than enough evidence to show that the behaviour of this effect has changed in ways that negatively impact this sequence.  I understand there were good reasons to rewrite the pinwheel effect.  I started reporting this in the other thread because I thought it was a bug in the .55 pinwheel update and I also am aware that was addressed in .56.  So now, this fantastic sequence is the unfortunate victim.

I moved the discussion over here because I believe the new updated pinwheel effect is going to impact anybody who purchases this sequence which makes use of the old pinwheel behavior.  And I would like to believe that Lilia is deservedly proud of her work and would want to make sure that it looks just as good on the current xLights release.

One final note: I have tried deleting the .fseq file and rerender.  Makes no difference.  I've tried this with my own show directory+models, with Sean's rgbeffects file+directory, and with a completely new, separate test directly and models.  Always the same. 

Offline Gilrock

  • Supporting Member
  • Hero Member
  • *
  • Posts: 6946
    • View Profile
Re: Lilia Sequence: Hallelujah (Full Model Version) by Pentatonix
« Reply #12 on: January 03, 2017, 07:36:29 PM »
Ok I'm not even going to read that past the 2nd sentence.  No I did not test it yet because I was at work when I replied.  I was just stating a fact because I was looking for differences between what you said you tested versus what I tested.  I didn't change the code that messed this up and I don't need to be yelled at so good luck with this.

Offline sean

  • Administrator
  • Hero Member
  • *****
  • Posts: 1727
    • View Profile
    • Xlights and Nutcracker Forum
Re: Lilia Sequence: Hallelujah (Full Model Version) by Pentatonix
« Reply #13 on: January 03, 2017, 08:32:42 PM »
Relax people. The code that Chris Debenham did to pinwheel fixed two things
1) Improved speed. Hallelujah went from 48 seconds to save to 29 secs
2) A larger fix was that it got rid of the holes in the effect on larger models

When 2016.55 came out, I told Chris about the break in the cross effect. Chris's code would not draw a line if the result of the calculation was less than 1 pixel (like .6 pixel). The old code did draw it.

This is not uncommon. fix a bug, introduce a bug. When version 56 came out I saw that the missing arm of the cross was back so stated it looked ok to me. On closer inspection, it is different. 2016.54 draws two lines on our megatree. 2016.56 draws one.

I ran Hallelujah in our show, we have a 16x50 megatree and a 16x120 megatree.

Give Chris time to look into the effect to see how it can be fixed.

PS: I have not show   Lilia what hallelujah looks like with 2016.56. I know she spent a few hours on just the cross. I will wait until we get it fixed.
Her OCD sequencing would prob flare up.
All other pinwheel effects look ok to me.

Thanks for pointing it out.

sean

Sean
Littleton, CO
Latest releases http://nutcracker123.com/nutcracker/releases
xLights/Nutcracker Forum http://nutcracker123.com/forum/index.php
Fbook [url=https://www.facebook.com/groups/62

Offline pixelpuppy

  • Jr. Member
  • **
  • Posts: 73
    • View Profile
Re: Lilia Sequence: Hallelujah (Full Model Version) by Pentatonix
« Reply #14 on: January 04, 2017, 11:00:12 AM »
Thanks, Sean.  That's the kind of response I was expecting.  I am not the type to post things frivolously.  I do lots of testing and research before I ever report any issues.  I never understand why Gil is always so quick to shoot down the facts that I report and then gets all defensive when I back it up with evidence. That's the only source of frustration. 

I understand there are good reasons for the pinwheel rewrite. I have no issue with that. Your comment about not showing it to Lilia validates what I have been saying all along.   Clearly there is some issue here that needs to be looked at.  Thank you for acknowledging it and that's all I needed.