Author Topic: Error after adding a point to an existing Poly Line when re-opening Xlights  (Read 723 times)

Offline thekameleon

  • Newbie
  • *
  • Posts: 40
    • View Profile
When I add a point to an existing Poly Line that I have already saved and that has individual segments nodes defined, everything appears to save without an issue.  However, when I close and re-open xlights, I get a dialog box stating that it could not open RGB Effects and my entire layout is wiped clean. (Thanks to how ever implemented the back up feature)
I dug into the RGBEffects.xml filke and found this:

    <model DisplayAs="Poly Line" StringType="RGB Nodes" StartSide="B" Antialias="1" PixelSize="2" Transparency="0" parm1="1" parm3="1" LayoutGroup="Default" Dir="L" name="Roof.Peak.1" IndivSegs="1" Seg5="47" Seg5="53" Seg4="155" Seg3="55" Seg1="41" Seg2="41" parm2="292" NumPoints="5" PointData="0.393333,0.749334,0.411333,0.774222,0.429333,0.799111,0.468178,0.798556,0.540000,0.734222" cPointData="" versionNumber="1" StartChannel="#192.168.1.41:28:1">
      <ControllerConnection/>
    </model>

The Seg5 attribute repeats itself. And looking at the prior saved versions it does not appear to clean up Segments that have been removed. I at one point had 5 segments but I changed it to 3, then added a 4th.  The 4th added point is when the error happens on re-opening xlights as mentioned above.

    <model DisplayAs="Poly Line" StringType="RGB Nodes" StartSide="B" Antialias="1" PixelSize="2" Transparency="0" parm1="1" parm3="1" LayoutGroup="Default" Dir="L" name="Roof.Peak.1" IndivSegs="1" Seg4="53" Seg5="47" Seg1="82" Seg2="55" Seg3="155" parm2="292" NumPoints="4" PointData="0.474667,0.736889,0.500667,0.784889,0.549512,0.786111,0.626000,0.707556" cPointData="" versionNumber="1" StartChannel="#192.168.1.41:28:1">
      <ControllerConnection/>
    </model>

I removed the two Seg5 attributes and so far everything seems ok.

Offline Gilrock

  • Supporting Member
  • Hero Member
  • *
  • Posts: 6946
    • View Profile
When I first wrote that model you're right I did not bother deleting segments that were deleted and unused because it didn't hurt anything.  My main reason was because I wanted it to retain the pixel size info for each segment if I unchecked the Indiv Segments option and then decide to recheck it again later.  But I thought later Keith added code that does delete them and clean it up.  At this point I wouldn't know how its working without testing.

Offline thekameleon

  • Newbie
  • *
  • Posts: 40
    • View Profile
Ok sounds good. Let me know, what you need from me. (i.e. RGBEffect files, etc..) I found a work around so I am not dead in the water.

Offline keithsw1111

  • Administrator
  • Hero Member
  • *****
  • Posts: 2733
    • View Profile
    • Kellyville Christmas Lights
What version are you using. Can you record a quick video showing how to reproduce the problem on .46.


Sent from my iPhone using Tapatalk

Offline thekameleon

  • Newbie
  • *
  • Posts: 40
    • View Profile
I am using 46. I could not reproduce the error by creating a new poly line.  However, if I took the existing poly line and copied into a new RGBEffects file and repeated the steps exactly as shown in the video then you will see the error.

The RGBEffects file and video are attached

Offline keithsw1111

  • Administrator
  • Hero Member
  • *****
  • Posts: 2733
    • View Profile
    • Kellyville Christmas Lights
Then don’t do that.


Sent from my iPhone using Tapatalk

Offline Gilrock

  • Supporting Member
  • Hero Member
  • *
  • Posts: 6946
    • View Profile
Yeah if it can't happen again with a new one then we probably fixed a bug at some point.  We don't go crazy trying to handle all the old errors that might be in files.

Offline thekameleon

  • Newbie
  • *
  • Posts: 40
    • View Profile
Then don’t do that.


Sent from my iPhone using Tapatalk

I did that just to reconstruct the error for you as you asked.