Possible bug in xLights FPP Connect double entries

[poporacer]

I am using 2019.54 but this was the same on .53 as well. When I use FPP Connect, it will show one of my sequences twice. I do not know why. I am not sure if I need to select both.

[dkulp]

.55 will have a lot more debug information in the FPP Connect file scan.   Once .55 comes out, could you try again and then look in the xLights log.  It may explain why in there.   

[poporacer]

Absolutely I will!

[poporacer]

I see that you are searching ALL of the subfolders for potential .FSEQ files? Is that a little overkill?
Here is what I found.

I have my Show directory and in that directory I have another directory of a downloaded sequence.

The downloaded sequence has a .FSEQ and .xml file that are the same as the Show directory but they are totally different. In this case, it will list the same sequence 2 times with the file path the same. (see attached pic) I don't know if it is actually pointing to the same file, or if it is pointing to the Show directory file on one and then pointing to the downloaded file for the other but displaying the path to the show directory? This could be bad. What happens if both are selected?

If I change the name of the .FSEQ so that it is different than the one in the Show directory, it will still show the sequences the same as before.

If I change both the .FSEQ file and the associated .xml file, then it will show both sequence files as expected. (see pic)

If I change just the .xml file in the downloaded directory to have a different name, then it only captures the sequences in the Show directory and lists the sequence one time. (see pic)

I attached the relevant portion of the log when I was doing these steps.

[dkulp]

Looks like the scanning is working correctly.   We have to scan all the subfolders as it's extremely common to have each sequence in it's own subdirectory of the show folder.   At that point, it's then whether we can match it up with an fseq file which is "by name".     So that part is correct. 

If both the media and fseq files are the same, we likely shouldn't add it to the list again.   Really no point.   So that should be filtered out. 

[poporacer]

I agree that it is scanning the folders correctly and there is no way to know what are the "good" files and after thinking about it there is no clean way to decide what folders could be excluded.

I don't think the logic is quite correct.

For example in my case, there are two distinct Ghostbuster.fseq and Ghostbuster.xml files in different directories and the FPP Connect shows two but they have the same file path. Is this showing the one file twice or pointing to the different files but displaying the paths incorrectly?

Shouldn't it display both Sequences with the separate paths so that the user can select the correct file to upload? As it is now, there is no way to select the file that is in the subfolder which could be the file that actually needs to be uploaded.