Author Topic: Crash 4.1.1  (Read 6586 times)

Offline Phrog30

  • Hero Member
  • *****
  • Posts: 1234
    • View Profile
Crash 4.1.1
« on: June 03, 2015, 07:25:54 AM »
I created a simple sequence for testing.  If I double click in the sequencer grid, the app will crash.  After looking around, it only happens when clicking outside of a timing mark.  So, if I have no timing marks, double clicking anywhere in the grid will cause a crash.  If I have timing marks, it will only crash if I click outside (to the right) of the last mark. 


[attachment deleted by admin]

Offline Gilrock

  • Supporting Member
  • Hero Member
  • *
  • Posts: 6946
    • View Profile
Re: Crash 4.1.1
« Reply #1 on: June 03, 2015, 07:30:57 AM »
And this didn't happen in the last version?

Offline Phrog30

  • Hero Member
  • *****
  • Posts: 1234
    • View Profile
Re: Crash 4.1.1
« Reply #2 on: June 03, 2015, 07:33:52 AM »
I don't know. I could install an earlier version and try.

Offline Gilrock

  • Supporting Member
  • Hero Member
  • *
  • Posts: 6946
    • View Profile
Re: Crash 4.1.1
« Reply #3 on: June 03, 2015, 07:38:44 AM »
That's up to you.  I can test it out either way but not till tonight.  It does make it easier when problems are posted for us to know if its a problem that just changed in the last release.

Hmm...just a quick browse of the code and we don't even define an event handler for double-click so the grid shouldn't be capable of receiving that event.  Only the waveform currently processes a double-click.

Offline Phrog30

  • Hero Member
  • *****
  • Posts: 1234
    • View Profile
Re: Crash 4.1.1
« Reply #4 on: June 03, 2015, 07:47:16 AM »
Installed 4.0.35, it was fine. Installed 4.1.0, it crashed. So, the last 2 releases.

Offline Phrog30

  • Hero Member
  • *****
  • Posts: 1234
    • View Profile
Re: Crash 4.1.1
« Reply #5 on: June 03, 2015, 07:49:37 AM »
I'm sorry, it does it on a single click as well. So I guess not specific to double click.

Offline Gilrock

  • Supporting Member
  • Hero Member
  • *
  • Posts: 6946
    • View Profile
Re: Crash 4.1.1
« Reply #6 on: June 03, 2015, 08:08:07 AM »
Ok then it must be the new logic trying to figure out where you selected in the grid.  It's failing because there is no timing effect above your click.

Offline Gilrock

  • Supporting Member
  • Hero Member
  • *
  • Posts: 6946
    • View Profile
Re: Crash 4.1.1
« Reply #7 on: June 03, 2015, 08:10:20 AM »
That's the problem when we do these rapid beta releases.  I think what's causing this crash is due to changes that were fixing another type of crash.

Offline flyinverted

  • Administrator
  • Hero Member
  • *****
  • Posts: 756
    • View Profile
Re: Crash 4.1.1
« Reply #8 on: June 03, 2015, 10:13:30 AM »
Here is what I see when I test

4.01.0   Left click on the sequencer with no timing mark = crash
4.01.01 Left click on the sequencer with no timing mark = no crash
4.01.01 Right click on the sequencer with no timing mark = crash

Steve Giron
Maricopa County, AZ
xLights user with a boat-load of channels.

Do not ask to know all the answers, but ask to understand the question.

Offline Gilrock

  • Supporting Member
  • Hero Member
  • *
  • Posts: 6946
    • View Profile
Re: Crash 4.1.1
« Reply #9 on: June 03, 2015, 10:49:44 AM »
Yeah I did a checkin last night before this release that I thought fixed the crash when left clicking in the grid with no timing mark.  When you reported the right click problem last night I couldn't repeat it so I thought those other changes I checked in after that had fixed it.  Usually I find people don't give me enough details when they talk about problems.  Thinking back I created a new sequence and right clicked in the timing row which didn't crash.  Left click was causing a crash so I fixed that one.  Since you are saying right click is still crashing I can only guess that maybe you added a model and are right clicking there.

Offline sean

  • Administrator
  • Hero Member
  • *****
  • Posts: 1727
    • View Profile
    • Xlights and Nutcracker Forum
Re: Crash 4.1.1
« Reply #10 on: June 03, 2015, 11:08:28 AM »
i cant seem to duplicate this. i have no timing marks, 80 models and carol of the bells.mp3

i click and double click all over the place, no crash.

could you film your screen with your phone and post the video someplace? That usually helps us see exactly how to duplciate what you do
Sean
Littleton, CO
Latest releases http://nutcracker123.com/nutcracker/releases
xLights/Nutcracker Forum http://nutcracker123.com/forum/index.php
Fbook [url=https://www.facebook.com/groups/62

Offline Phrog30

  • Hero Member
  • *****
  • Posts: 1234
    • View Profile
Re: Crash 4.1.1
« Reply #11 on: June 03, 2015, 11:32:58 AM »
Gil, were you able to duplicate?

Offline Gilrock

  • Supporting Member
  • Hero Member
  • *
  • Posts: 6946
    • View Profile
Re: Crash 4.1.1
« Reply #12 on: June 03, 2015, 11:38:15 AM »
Sorry gotta finish my day job....can't test till tonight.

Offline Phrog30

  • Hero Member
  • *****
  • Posts: 1234
    • View Profile
Re: Crash 4.1.1
« Reply #13 on: June 03, 2015, 12:22:03 PM »
No problem, just curious. I won't be able to make a video for a few days.

Offline flyinverted

  • Administrator
  • Hero Member
  • *****
  • Posts: 756
    • View Profile
Re: Crash 4.1.1
« Reply #14 on: June 03, 2015, 12:44:03 PM »
Here's the video. All clicks were with the left mouse button. Sean, I used your setup.

http://stevesimages.com/xl4/xl4-click-crash.mp4

I know.. there's absolutely no valid reason to click on an empty panel because there's nothing you can do there.
« Last Edit: June 03, 2015, 12:55:27 PM by flyinverted »
Steve Giron
Maricopa County, AZ
xLights user with a boat-load of channels.

Do not ask to know all the answers, but ask to understand the question.